Added missing tests, new configuration with HikariCP and bumped Play version #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumped Play version to 2.3.6. Added HikariCP benchmark config.
msmith-techempower
added a commit
that referenced
this pull request
Oct 29, 2014
Added missing tests, new configuration with HikariCP and bumped Play version
|
👍 I think this PR looks great. I have a few suggestions but there's no rush on these things. You can easily change them up in your next PR. |
| ('Scala', 'Slick', ['Linux'], ['db', 'query', 'fortune', 'update']), | ||
| ('Java', None, ['Linux'], ['json']), | ||
| ('Java', 'Ebean', ['Linux'], ['db', 'query']), | ||
| ('Java', 'JPA', ['Linux'], ['db', 'query', 'fortune', 'update', 'plaintext']), |
There was a problem hiding this comment.
I suggest renaming "JPA" to "JPA BoneCP" here so that the difference between the two frameworks is really clear. I understand that BoneCP is the default but I don't think it will hurt to spell out the difference to anyone who is reading the results!
donovanmuller
added a commit
to donovanmuller/FrameworkBenchmarks
that referenced
this pull request
Nov 3, 2014
Updated Ebean benchmarks to include missing tests as well as include HikariCP version. Moved `/plaintext` tests from JPA/Ebean benchmarks to the `play2-java` benchmark as per TechEmpower#1149 (comment) Added BoneCP qualifier as per TechEmpower#1149 (comment) and changed names accordingly.
donovanmuller
added a commit
to donovanmuller/FrameworkBenchmarks
that referenced
this pull request
Nov 3, 2014
Updated Ebean benchmarks to include missing tests as well as include HikariCP version. Moved `/plaintext` tests from JPA/Ebean benchmarks to the `play2-java` benchmark as per TechEmpower#1149 (comment) Added BoneCP qualifier as per TechEmpower#1149 (comment) and changed names accordingly.
|
@richdougherty Have implemented your suggestions here as well as updating Ebean benchmark etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the remaining tests for
play2-java-jpa:Also added a new benchmark configuration based on
play2-java-jpabut using the HikariCP plugin. This allows the default BoneCP connection pool to be replaced with HikariCP.