Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Crystal #1623

Merged
merged 3 commits into from May 26, 2015
Merged

Add Crystal #1623

merged 3 commits into from May 26, 2015

Conversation

will
Copy link
Contributor

@will will commented May 25, 2015

Only the JSON and Plain Text tests, but it's a start.

@will will mentioned this pull request May 25, 2015
@msmith-techempower
Copy link
Member

Is there no framework being exercised? What is the reason for the directory being called "stdlib" instead of "crystal-raw" or similar?

@will
Copy link
Contributor Author

will commented May 26, 2015

Is there no framework being exercised?

Correct

What is the reason for the directory being called "stdlib" instead of "crystal-raw" or similar?

I wasn't aware of the naming conventions. I can change it to crystal-raw :)

@msmith-techempower
Copy link
Member

Great, crystal-raw sounds good. Also, after you do that, I think we can safely merge it in since Travis-CI has checked it.

@will
Copy link
Contributor Author

will commented May 26, 2015

Updated, thanks!

Question for future tests: Were I to include a postgres driver for the database tests, would that still fit under -raw?

@msmith-techempower
Copy link
Member

Yeah, if you plan on including the database tests, I would suggest adding them to the raw one you have here.

LGTM!

msmith-techempower added a commit that referenced this pull request May 26, 2015
@msmith-techempower msmith-techempower merged commit 4265e57 into TechEmpower:master May 26, 2015
@5nyper
Copy link

5nyper commented May 27, 2015

Someone is working on a framework on Crystal called Moonshine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants