Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up axum benchmarks #7484

Merged
merged 10 commits into from Jul 29, 2022
Merged

Clean up axum benchmarks #7484

merged 10 commits into from Jul 29, 2022

Conversation

jplatte
Copy link
Contributor

@jplatte jplatte commented Jul 21, 2022

cc @dragosv who added the axum benchmarks.

@dragosv
Copy link
Contributor

dragosv commented Jul 21, 2022

@nbrady-techempower can you approve the PR?

@fundon
Copy link
Contributor

fundon commented Jul 22, 2022

https://github.com/TechEmpower/FrameworkBenchmarks/blob/master/frameworks/Rust/actix/Cargo.toml#L66-L69

I think all rust frameworks need sync [profile.release].

@jplatte
Copy link
Contributor Author

jplatte commented Jul 22, 2022

That's already there. It misses one setting from the actix config, but that's default for the release profile anyways AFAIK.

@NateBrady23 NateBrady23 merged commit 485bc45 into TechEmpower:master Jul 29, 2022
@jplatte jplatte deleted the axum branch July 29, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants