Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PHP Nette Framework #7817

Merged
merged 6 commits into from
Dec 27, 2022
Merged

Added PHP Nette Framework #7817

merged 6 commits into from
Dec 27, 2022

Conversation

n0nag0n
Copy link
Contributor

@n0nag0n n0nag0n commented Dec 21, 2022

Added the PHP Nette Framework.

@n0nag0n n0nag0n changed the title Php nette Added PHP Nette Framework Dec 21, 2022
frameworks/PHP/nette/benchmark_config.json Outdated Show resolved Hide resolved
frameworks/PHP/nette/benchmark_config.json Outdated Show resolved Hide resolved
frameworks/PHP/nette/benchmark_config.json Outdated Show resolved Hide resolved
@n0nag0n
Copy link
Contributor Author

n0nag0n commented Dec 21, 2022

Side note, with PHP are you guys allowing opcache.preload scripts or are you trying to compare all frameworks against not preloading scripts? https://www.php.net/manual/en/opcache.preloading.php

@joanhey
Copy link
Contributor

joanhey commented Dec 21, 2022

You can use preload script.
But with PHP8.1, the difference is minimal

Some frameworks use it, and others not.

@joanhey
Copy link
Contributor

joanhey commented Dec 21, 2022

You can delete the robots.txt file. It isn't use it in the benchmark.

@n0nag0n
Copy link
Contributor Author

n0nag0n commented Dec 21, 2022

Deleted the file......forgot to use [ci skip] :(

@joanhey
Copy link
Contributor

joanhey commented Dec 21, 2022

Are you familiar with Laminas framework?

Because my implementation, still don't work. :(

@n0nag0n
Copy link
Contributor Author

n0nag0n commented Dec 21, 2022

I'll be honest, this was a beast to get working in the vagrant box, but I finally got everything working and running. I'm familiar with Laminas but not in building with Laminas. I basically created a skeleton Nette app, got that working in a different repo, then copied the files over.

@joanhey
Copy link
Contributor

joanhey commented Dec 21, 2022

OK
But you know Fat-Free
I need a hand with Fat-free. Send me a mail.

@n0nag0n
Copy link
Contributor Author

n0nag0n commented Dec 21, 2022

Sent ya an email

@joanhey
Copy link
Contributor

joanhey commented Dec 26, 2022

#7703
👍

@NateBrady23 NateBrady23 merged commit c824451 into TechEmpower:master Dec 27, 2022
@joanhey
Copy link
Contributor

joanhey commented Jan 4, 2023

Nette average very bad in this benchmark.
It's normal after read that:
https://forum.nette.org/en/21784-persistent-connection-to-mysql-database

I had a large discussion, for the same, with Doctrine.
Now they fix it.

@n0nag0n
Copy link
Contributor Author

n0nag0n commented Jan 5, 2023

Yes I noticed the same. I did ask a question and then @Rixafy on discord let me know if one change I can make. https://forum.nette.org/en/35661-techempower-benchmarks-needs-help I can make the one change but it may need more help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants