Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-fiber added scratch docker image, bumped golang version #8201

Closed
wants to merge 7 commits into from
Closed

go-fiber added scratch docker image, bumped golang version #8201

wants to merge 7 commits into from

Conversation

lospejos
Copy link
Contributor

@lospejos lospejos commented May 8, 2023

go-fiber added scratch docker image, bumped Golang version to 1.20

@lospejos lospejos changed the title go-fiber added sratch docker image, bumped golang version go-fiber added scratch docker image, bumped golang version May 8, 2023
@joanhey
Copy link
Contributor

joanhey commented May 10, 2023

Hi @lospejos
I understand the advantages of using an scratch docker image.
But in the benchmark, please could you explain the benefit ?
Because we are testing exactly the same binary.

I think that we need to create an issue, about that, as some frameworks are already repeating the test.

@lospejos
Copy link
Contributor Author

But in the benchmark, please could you explain the benefit?

Well, my main concern was to test exact the same things we do use in general / production. Besides, since there are exact the same binaries, and scratch variant consumes less resources (disk space), why not to use it?

I didn't made thorough tests, but what chances are that when using scratch image we can get less overhead (getting rid of OS context switches, resources consumption of other background processes in OS that require resources etc)?

Anyway, this is just my proposal, and you are free to reject it.

@joanhey
Copy link
Contributor

joanhey commented May 28, 2023

Thank you for the answer.

I didn't say to not use scratch docker, only decide with or without. Because the others frameworks have the same results.
Please check #8209

Now I'll show you some results, from the actual run:
image

image
image

From last run:
image
image

I understand to try it with one fw, that is well maintained, to know if exist big variations.
But all the results are the same.

Do you think that we need to use the two variants in all frameworks, to have the same results?

@NateBrady23
Copy link
Member

Closing as this seems out of date. Feel free to re-open if you have time to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants