Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[php] Ubiquity update to PHP 8.3 #8600

Merged
merged 8 commits into from
Dec 11, 2023
Merged

[php] Ubiquity update to PHP 8.3 #8600

merged 8 commits into from
Dec 11, 2023

Conversation

joanhey
Copy link
Contributor

@joanhey joanhey commented Nov 29, 2023 •
edited

Ngx-php only to PHP 8.2
Update ngx-php to 0.0.28, php 8.3, nginx 1.25.3 and ubuntu 22.04

@joanhey
Copy link
Contributor Author

joanhey commented Nov 29, 2023

Ping @jcheron

@jcheron
Copy link
Contributor

jcheron commented Nov 30, 2023

Hi @joanhey
Thanks, I'll look at it this weekend

@jcheron
Copy link
Contributor

jcheron commented Dec 2, 2023

On php attributes, reference to the root namespace is apparently mandatory:

#[\AllowDynamicProperties()]

see https://github.com/phpMv/FrameworkBenchmarks/actions/runs/7071626460

@jcheron
Copy link
Contributor

jcheron commented Dec 3, 2023

The AllowDynamicProperties attribute is missing from the World model.

@joanhey
Copy link
Contributor Author

joanhey commented Dec 8, 2023

@jcheron check myaaghubi/PHP-Frameworks-Bench#49

@NateBrady23 NateBrady23 merged commit 208c989 into TechEmpower:master Dec 11, 2023
3 checks passed
@joanhey joanhey deleted the ubiquity-8.3 branch December 11, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: Please Update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joanhey @jcheron @NateBrady23