Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finagle #95

Merged
merged 1 commit into from
Apr 8, 2013
Merged

Finagle #95

merged 1 commit into from
Apr 8, 2013

Conversation

Falmarri
Copy link

@Falmarri Falmarri commented Apr 5, 2013

I added finagle/slick

@TechEmpower
Copy link
Collaborator

Oh awesome. Thank you! I'll delete issue #86 that I just created, and which is now closed. :)

@TechEmpower TechEmpower merged commit 1f0aeaf into TechEmpower:master Apr 8, 2013
@TechEmpower
Copy link
Collaborator

Thanks @Falmarri. As a note, the JSON numbers look great, but the database/multi query test look a bit slow. I can't be sure, but I suspect that a connection pool isn't set up. Any ideas?

@Falmarri
Copy link
Author

Falmarri commented Apr 8, 2013

@TechEmpower Honestly I've never used Slick before, so it could be. I'll look into it since I should probably learn it anyway. I'm sure there are lots of optimizations I'm missing.

@fernandezpablo85
Copy link

@Falmarri do you think you could use finagle-mysql instead of slick? I think that would make finagle run even faster

@Falmarri
Copy link
Author

Falmarri commented May 3, 2013

@fernandezpablo85 I've never actually used finagle-mysql but sure I'll give it a try. I'm not sure it'd be totally fair though. As far as I know it's barely even a beta-quality project. I'll put in the new fortune test as well. Slick's overhead might be reduced in terms of a more complex query.

@pfalls1
Copy link
Contributor

pfalls1 commented May 3, 2013

@Falmarri and @fernandezpablo85, thanks for looking into this.

Also, looking forward to the Fortune test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants