Remove TheUnderground
from softdepend
#2010
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See rationale on issue #2009, in particular #2009 (comment)
... but recent changes to Paper in PaperMC/Paper#8108 have caused a circular dependency error to be triggered by this - we (soft-!)depend on
TheUnderground
, which depends on GriefPrevention, and boom. I'd argue that a softdepend should not be considered a circular dependency really, but it is, currently, and results in an error like:TheUnderground
appears to only work on 1.10, and current GriefPrevention builds don't support anything that ancient, so there doesn't seem to be much point in maintaining it in the softdepends list. It also doesn't look widely used anyway.Note that it was already removed from
loadbefore
in 6d0a1b9