Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TheUnderground from softdepend #2010

Conversation

bigpresh
Copy link
Collaborator

See rationale on issue #2009, in particular #2009 (comment)

... but recent changes to Paper in PaperMC/Paper#8108 have caused a circular dependency error to be triggered by this - we (soft-!)depend on TheUnderground, which depends on GriefPrevention, and boom. I'd argue that a softdepend should not be considered a circular dependency really, but it is, currently, and results in an error like:

[11:26:57 ERROR]: [ConfiguredOrderedProviderStorage] Circular dependencies detected!
[11:26:57 ERROR]: [ConfiguredOrderedProviderStorage] You have a plugin that is depending on a plugin which refers back to that plugin. Your server will shut down until these are resolved, or the strategy is changed.
[11:26:57 ERROR]: [ConfiguredOrderedProviderStorage] Circular dependencies:
[11:26:57 ERROR]: [ConfiguredOrderedProviderStorage] GriefPrevention depends on TheUnderground depends on GriefPrevention...

TheUnderground appears to only work on 1.10, and current GriefPrevention builds don't support anything that ancient, so there doesn't seem to be much point in maintaining it in the softdepends list. It also doesn't look widely used anyway.

Note that it was already removed from loadbefore in 6d0a1b9

See rationale on issue GriefPrevention#2009, in particular:
GriefPrevention#2009 (comment)

... but recent changes to Paper have caused a circular dependency error
to be triggered by this - we (soft-!)depend on TheUnderground, which
depends on GriefPrevention, and boom.  I'd argue that a softdepend
should not be considered a circular dependency really, but it is,
currently.

TheUnderground appears to only work on 1.10, and current GriefPrevention
builds don't support anything that ancient, so there doesn't seem to be
much point in maintaining it in the softdepends list.

Note that it was already removed from `loadbefore` in 6d0a1b9
Copy link

@Owen1212055 Owen1212055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was already fixed by me in #1912

The issue is that the plugin author has not released an update.

@bigpresh
Copy link
Collaborator Author

This was already fixed by me in #1912

Ahh, thank you - it wasn't clear to me that removing it from loadbefore would solve the circular dep issue. Thanks for your explanation on that PR on softdepend vs loadbefore.

I'll leave this PR open for now for opinions from @RoboMWM et al, as I still think it sounds sensible to entirely remove TheUnderground, as a closed-source plugin that as far as I can tell only works with older MC versions.

@RoboMWM
Copy link

RoboMWM commented Feb 20, 2023

I've only left it there because I've never looked into that plugin nor seen if it's needed for anything. If it is indeed out of date and not usable/being used, then I'll drop it completely. No need to softdepend on something this plugin does not use, though I guess that applies to a lot of the plugins listed in there anyway...

I wonder if there's a way to design the plugin to not need to softdepend. Maybe loading claims on ServerLoadFinishedEvent or whatever it's called.

@RoboMWM RoboMWM merged commit 23e0dd9 into GriefPrevention:master Feb 20, 2023
@c0wg0d
Copy link

c0wg0d commented Mar 14, 2023

I was a huge fan of TheUnderground. It probably had softdepend support because it generated a new world. It was made by minelazz, who is the author of EpicWorldGenerator and EpicNetherGenerator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants