Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated github URLs #101

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Updated github URLs #101

merged 2 commits into from
Oct 18, 2023

Conversation

TORlN
Copy link
Contributor

@TORlN TORlN commented Oct 17, 2023

replaced all instances of the string "gorillamania" with "TechNickAI"

@TechNickAI
Copy link
Owner

Hey @TORlN this is mostly fine as is, but since I want to also make this a learning exercise for you, I'll be more thorough than normal and advise on some best practices.

  1. CHANGELOG.md is auto generated from a tool called symantic release so no need to edit that one. You can leave the changes, they will be overwritten next time I do a release.

  2. I triggered the build process to run, and the Super Linter failed. I don't think that was your changes - but would you mind cleaning that up as part of this PR? Again, don't worry about CHANGELOG. https://github.com/TechNickAI/AICodeBot/actions/runs/6551811343/job/17797440429?pr=101

  3. The name of the branch is just "working". People use a more descriptive branch name that is specific to the task. Read up on best practices for naming a branch. Don't change it for this one, just FYI for future work.

@TORlN
Copy link
Contributor Author

TORlN commented Oct 17, 2023 via email

@TORlN
Copy link
Contributor Author

TORlN commented Oct 18, 2023

I added a newline character to line 194 in the readme because super-linter was complaining about that line being over 400 characters. I also specified, on line 219, that the code below was a shell command to appease super-linter.

I left all changelog errors alone.

@TechNickAI
Copy link
Owner

Looks good. Thank you for your first contribution @TORlN!

@TechNickAI TechNickAI merged commit 67d5409 into TechNickAI:main Oct 18, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants