Generic bucket model not working properly with resource pack

[ghost]

Describe the bug
My resource pack replaces the textures for your universal bucket model (for liquids from your mod), but it does not work correctly in the game.

Steps to Reproduce
Steps to reproduce the behavior:

• Install Tech Reborn
• Apply my resource pack

Screenshots

Environment (please complete the following information with the version):

• Minecraft: 1.19.3
• Mod Loader: fabric
• Fabric Loader: 0.14.11
• Fabric API: 0.69.0
• Mod Menu: 5.0.2
• Reborn Core: 5.5.0
• Tech Reborn: 5.5.0

Logs
latest.log

Additional context
Link to my resource pack

[xanthian]

Whats wrong with it? (apart from being 32x) 👎🏼

[ghost]

Whats wrong with it? (apart from being 32x) 👎🏼

The bucket part works fine, but the part of the texture that is automatically colored depending on the content (from the modification) does not change to the texture from my resource pack. At the same time, the names of the files, their paths and transparency parameters are normal.

[Ayutac]

Why would it change though?

[ghost]

Why would it change though?

So that the mod normally uses resource packs? I do not understand your question.

[xanthian]

I'm massively confused here.
Which bit isn't changing?

[ghost]

I'm massively confused here. Which bit isn't changing?

Look, instead of a couple dozen textures for each bucket of liquid (for example, sodium), the mod uses a universal bucket model. It consists of two textures, it is backet_background.png and bucket_base.png. Here they are in the mod's file structure:

In my resource pack, I make both of these textures at 32x, but only backet_background.png from resourcepack is used in the game.

[xanthian]

So the fluid texture. Why not just say that. Not sure how this is a TR issue??

…

________________________________ From: Alex ***@***.***> Sent: Tuesday, December 13, 2022 7:20:04 AM To: TechReborn/TechReborn ***@***.***> Cc: xanthian ***@***.***>; Comment ***@***.***> Subject: Re: [TechReborn/TechReborn] Generic bucket model not working properly with resource pack (Issue #3090) I'm massively confused here. Which bit isn't changing? Look, instead of a couple dozen textures for each bucket of liquid (for example, sodium), the mod uses a universal bucket model. It consists of two textures, it is backet_background.png and bucket_base.png. Here they are in the mod's file structure: [https://camo.githubusercontent.com/10824ff65e52ff74fa4d80afb1d64b387212bcc1ef08b6fa2ba27333cd4f1b45/68747470733a2f2f696d61676575702e72752f696d673238352f343131303338322f73637265656e73686f745f312e706e67]<https://camo.githubusercontent.com/10824ff65e52ff74fa4d80afb1d64b387212bcc1ef08b6fa2ba27333cd4f1b45/68747470733a2f2f696d61676575702e72752f696d673238352f343131303338322f73637265656e73686f745f312e706e67> In my resource pack, I make both of these textures at 32x, but only backet_background.png from resourcepack is used in the game. — Reply to this email directly, view it on GitHub<#3090 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AB2U6QK7BHY54BQUEHFJNITWNAPSJANCNFSM6AAAAAAS3GYENM>. You are receiving this because you commented.Message ID: ***@***.***>

[ghost]

So the fluid texture. Why not just say that. Not sure how this is a TR issue?? Get Outlook for Androidhttps://aka.ms/AAb9ysg

I'm not sure if the universal bucket model is RebornCore, but the textures I changed belong to TechReborn.

[drcrazy]

Can you try with minecraft buckets?

I think we don't actually use TR bucket textures.

TechReborn/src/client/java/techreborn/TechRebornClient.java

Line 121 in 48f312d

return JsonUnbakedModel.deserialize("{\"parent\":\"minecraft:item/generated\",\"textures\":{\"layer0\":\"minecraft:item/bucket\"}}");

[drcrazy]

Is it still reproducible in 1.20?