feat+fix: modify configs and refactor cli #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyleTryon
approved these changes
Jul 9, 2023
There was a problem hiding this comment.
Massively appreciate everything you did here @zenhorace. 🙏 This helped me understand a few things about Go and really set us up for a much better foundation moving forward. Huge thanks to you.
| @@ -10,14 +10,14 @@ import ( | |||
|
|
|||
| "github.com/AlecAivazis/survey/v2" | |||
| "github.com/spf13/cobra" | |||
| "github.com/techsquidtv/uhs-cli/cmd/common" | |||
| configCommon "github.com/techsquidtv/uhs-cli/models/common" | |||
| "github.com/techsquidtv/uhs-cli/cmd/shared" | |||
| if !ok { | ||
| return nil, fmt.Errorf("unregistered service name: %q", key) | ||
| } | ||
| sc := v() |
|
I'm going to accept everything as it is now, it won't get tagged right away, so we have time to change things before then. |
|
welp i messed something up there, that was a mistake. instead of pushing to your main i did mine somehow. all cool.. going to fix this retroactively real fast. not the best outcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a lot, in short:
I know it's a lot (and you may not like the approach), so take your time, and we can discuss it.