FKITDEV-2587: debug connection url #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bencelaszlo
reviewed
May 14, 2024
src/QueueConnection.js
Outdated
| const connection = await amqp.connect(configUrl, options) | ||
| this._activeConnectionConfig = connectionUrl | ||
| return connection | ||
| try{ |
There was a problem hiding this comment.
NIT: a try mögül hiányzik egy szóköz.
src/QueueConnection.js
Outdated
| return connection | ||
| } catch (error) { | ||
| this._logger.error('RabbitMQ connection failed to host:', { ...connectionUrl, password: connectionUrl.password ? '***' : connectionUrl.password }) | ||
| throw new Error('RabbitMQ connection failed with single url') |
There was a problem hiding this comment.
Ez így pontosan azt csinálja, mint a _connectWithMultipleUrls, ami jó, csak elkerülhetnénk a dupla karbantartását ugyanannak a logikának, ha a konfigból mindenképpen létrehoznánk egy tömböt és inline-olnánk ide a _connectWithMultipleUrls-t.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hasznos lenne, ha tudnánk, hogy melyik rabbitmq-hoz nem sikerült csatlakozni.
Javaslom, hogy a QueueConnection-ben a csatlakozás sikertelensége esetén írjuk ki, hogy melyik url-hez való csatlakozáskor történt a hiba.
https://youtrack.techteamer.com/issue/FKITDEV-2587/RabbitMQ-csatlakozasi-hiba-debug