Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: s3 bucket deprecated arguments #67

Conversation

blimmer
Copy link

@blimmer blimmer commented May 15, 2022

This PR resolves the following deprecations for arguments to s3 buckets:

│ Warning: Argument is deprecated
│
│   with module.travel_blog.module.cloudfront.aws_s3_bucket.wordpress_bucket,
│   on .terraform/modules/travel_blog/modules/cloudfront/distribution.tf line 4, in resource "aws_s3_bucket" "wordpress_bucket":
│    4: resource "aws_s3_bucket" "wordpress_bucket" {
│
│ Use the aws_s3_bucket_server_side_encryption_configuration resource instead
│
│ (and 5 more similar warnings elsewhere)
│ Warning: Argument is deprecated
│
│   with module.travel_blog.module.codebuild.aws_s3_bucket.code_source,
│   on .terraform/modules/travel_blog/modules/codebuild/main.tf line 8, in resource "aws_s3_bucket" "code_source":
│    8:   acl           = "private"
│
│ Use the aws_s3_bucket_acl resource instead
│
│ (and one more similar warning elsewhere)

@blimmer blimmer requested a review from petewilcock as a code owner May 15, 2022 01:31
@blimmer
Copy link
Author

blimmer commented May 15, 2022

Ah, I see this is done in #55 .

@blimmer blimmer closed this May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant