Skip to content
This repository has been archived by the owner on May 11, 2021. It is now read-only.

Pagination #13

Merged
merged 3 commits into from Jan 31, 2019
Merged

Pagination #13

merged 3 commits into from Jan 31, 2019

Conversation

itedwards
Copy link
Collaborator

No description provided.

@suninthesky suninthesky self-requested a review January 30, 2019 14:35
suninthesky
suninthesky suggested changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@suninthesky suninthesky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. I've suggested a few changes to limit the overall footprint of changes necessary - thinking about long term maintainability.

app/assets/stylesheets/base.sass Outdated Show resolved Hide resolved
app/assets/stylesheets/base.sass Show resolved Hide resolved
app/views/layouts/application.html.erb Outdated Show resolved Hide resolved
test/system/unknowns_test.rb Show resolved Hide resolved
suninthesky
suninthesky approved these changes Jan 31, 2019
View reviewed changes
Copy link
Contributor

@suninthesky suninthesky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge.

@itedwards itedwards merged commit 8cd9af8 into dev Jan 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@suninthesky suninthesky suninthesky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@itedwards @suninthesky @ianedwards