Add Docker functionality for Solder #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pyker
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Docker functionality to TechnicSolder. Docker gives the solder user the ability to quickly setup an instance without needing to worry about what software runs on their system. As long as they can install Docker / Docker Compose, this will run. I was setting it up for a separate project (Endermedia solder) and worked a little with Pyker. There was another open PR, but it doesn't really work and doesn't have any contextual information. So with some help, I set this up and tested for reproducibility by following the steps outlined in the readme.
This PR makes zero changes to the app or php. It just adds some docker stuff. It won't effect solder if a person chooses to not use it. But if they do choose to use it, it can save them some time in getting things setup.
If there was any sort of setup that I missed along the way, please let me know. For example, I didn't know Redis was a thing before starting this xD. I'm not sure if it's setup correctly but everything appeared to work with it.