Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMI Integration #126

Merged
merged 3 commits into from
Dec 27, 2023
Merged

EMI Integration #126

merged 3 commits into from
Dec 27, 2023

Conversation

shartte
Copy link
Collaborator

@shartte shartte commented Dec 27, 2023

image
image
image
image
image

@shartte
Copy link
Collaborator Author

shartte commented Dec 27, 2023

@Technici4n Do we want to limit it to buckets retrieved from the Fluid instead of finding "all buckets" for fluids?
That would get rid of the fish buckets as coolant.................

@Technici4n
Copy link
Owner

A trick I like to use is to get the bucket from the fluid and make sure it matches the fluid you get from the bucket.

@shartte
Copy link
Collaborator Author

shartte commented Dec 27, 2023

A trick I like to use is to get the bucket from the fluid and make sure it matches the fluid you get from the bucket.

Sure, but you'd say the general approach to just use Fluid->bucket instead of finding all buckets is fine?
I think in the recipe viewer mod, it should be enough to indicate to players they can use buckets. It's not as important to list ALL buckets.

@Technici4n
Copy link
Owner

Yeah, whatever as long as we get rid of the fish buckets.

@shartte shartte merged commit f56db45 into 1.20 Dec 27, 2023
2 checks passed
@shartte shartte deleted the emi branch December 27, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants