Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sofie & Wen | Aspire Yoga #40

Open
wants to merge 63 commits into
base: main
Choose a base branch
from
Open

Sofie & Wen | Aspire Yoga #40

wants to merge 63 commits into from

Conversation

wwenzz
Copy link

@wwenzz wwenzz commented Apr 26, 2024

Netlify link

https://aspire-yoga.netlify.app/

Collaborators

[SofieFerrari]

wwenzz and others added 30 commits April 22, 2024 13:58
made discover-button for cards
wwenzz and others added 28 commits April 24, 2024 14:58
Copy link

@AntonellaMorittu AntonellaMorittu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sofie & Wen, congratulations for completing your week 12 project. It looks ✨ awesome ✨ and I want to praise your work and achievement! The site looks very close to the design and follows our requirements. How did you like Tailwind? It seems like you tackled it correctly and implemented a great result! Now the design is not pixel-perfect, but that's okay, here's some little things that can be taken into consideration to improve it even further:

  • use the same colour codes as the design and the same content. If you have a different opinion about the text, talk to the designer and agree on a better suitable solution together
  • Spaces in "Join our online membership" section are not exactly the same
  • columns gap are slightly bigger than the ones in the design

I think you nailed it, so well done! ⭐ ⭐ ⭐

colors: {
'primary-black': '#444446',
'secondary-ivory': '#FFF5EB',
'neutral-milk': '#F8F7F3',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this color code from the design should be #FFF5EB

Copy link

@Martin-Joensson Martin-Joensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job Sofie & Wen! It looks really professional and clean. Your code is easy to follow the logic of.
Go team Moon!
/Martin & Mai

>
Yearly
</button>
</>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we told you during the demo but we really like the way you solved the pill-button!
Martin & Mai

'Press',
];

const socialMeida = [

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big thing but just a typo =)
Martin & Mai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants