Week 12: Design handoff - Alma and Etna #49
Conversation
There was a problem hiding this comment.
Hi Alma & Etna, congratulations for completing your week 12 project. It looks ✨ awesome ✨ The site looks very close to the design and followed our requirements. How did you like Tailwind? Seems like you tackled it in the right way and implemented a great result! How cool you created your own carousel! Now the design is not pixel perfect, but that's okay, here's a little things that can be taken into consideration to improve it even further:
- Spaces and passings are not exactly the same
- hovering state can be added to all elements and buttons
- columns gap/proportions are slightly off compared to the ones in the design
I think you nailed it, so well done! ⭐
There was a problem hiding this comment.
here two, format to 2spaces indentation 👍
| @@ -0,0 +1,50 @@ | |||
| import { ButtonFAQ } from "./reusable/ButtonFAQ"; | |||
There was a problem hiding this comment.
Nice that you made the button reusable!
//Izabel, Linda
| touchEndX.current = e.touches[0].clientX | ||
| } | ||
|
|
||
| const handleTouchEnd = () => { |
| {feedback.feedback.map((_, index) => { | ||
| return ( | ||
| <button | ||
| className="bg-grey-dot2 hover:bg-grey-dot1 w-2 h-2 rounded-full border-none outline-none mx-1 cursor-pointer" |
There was a problem hiding this comment.
When sliding, the button doesn't get darker. We guess it should show the card the user is on at the moment.
//Izabel, Linda
| import data from "../json/links.json" | ||
|
|
||
| export const Footer = () => { | ||
| const getLinks = (startIndex, endIndex) => { |
There was a problem hiding this comment.
Nice touch that you made jsons for all the data.
//Izabel, Linda
| return ( | ||
| <div | ||
| className={`flex flex-col w-64 h-96 mb-28 mx-auto tablet:flex-row tablet:w-96 tablet:mx-8 tablet:items-center tablet:h-80 desktop:flex-col ${ | ||
| currentCard === false && "hidden" |
There was a problem hiding this comment.
Cool way to show the card that the user is currently on.
//Izabel, Linda
Netlify link
https://urban-spin.netlify.app/
Collaborators
[Caracal23]