project-design-handoff-vite #51
Conversation
|
hey! The link is not the one to the deployed version but to your personal Netlify page I can't access, please provide the right one :) |
|
Hi! I just updated the PR and here is the link to deployed version :)
https://clever-selkie-dfebb0.netlify.app/
…On Thu, 2 May 2024 at 13:41, Antonella Morittu ***@***.***> wrote:
hey! The link is not the one to the deployed version but to your personal
Netlify page I can't access, please provide the right one :)
—
Reply to this email directly, view it on GitHub
<#51 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BESF4YONHS5D7KUCFYXZOOLZAIQ5PAVCNFSM6AAAAABG5EUAZWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJQGI4TCOBRGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Hello Annika and Ji, congratulations for completing your week 12 project. Well done 🏅 The site looks very close to the design and followed our requirements. How did you like Tailwind? Seems like you tackled it in the right way and implemented a great result! How cool you created the carousel using a react library! Now the design is not pixel perfect, but that's okay, here's a little things that can be taken into consideration to improve it even further:
- on tablet, check all sizes are covered. On width 1024 "who we are/our trainers" buttons are missing
- accessibility: you scored 85 minimum needed is 95
Fix these little things and you're clear! 🚀 💪
There was a problem hiding this comment.
Hi! I reformatted the footer.jsx a bit, but unsure if it's what you were looking for. Please let me know if there's anything else here to change :)
There was a problem hiding this comment.
that's it, format removes empty lines and fixes the indentation! :)
There was a problem hiding this comment.
that's it, format removes empty lines and fixes the indentation! :)
Netlify link
https://clever-selkie-dfebb0.netlify.app/
Collaborators
[annsig]