Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Route: "default" route #211

Closed
alonttal opened this issue Mar 28, 2018 · 1 comment
Closed

New Route: "default" route #211

alonttal opened this issue Mar 28, 2018 · 1 comment
Assignees
@alonttal
Labels
Back-End MUST
Projects
Roommates
Milestone
Mid Semester POC

Comments

@alonttal
Copy link
Collaborator

alonttal commented Mar 28, 2018 •
edited

This route will handle any "invalid" request.
It will return HTTP 404.

Note that this is a MUST in order for the server not to crash on various circumstances, such as email verification (if you don't belive me, you can check it yourself :-) ).

Estimated time: 0.5 hour.
@alonttal alonttal added this to the Mid Semester POC milestone Mar 28, 2018
@alonttal alonttal self-assigned this Mar 28, 2018
@alonttal alonttal added this to Backlog in Roommates via automation Mar 28, 2018
@alonttal alonttal mentioned this issue Mar 28, 2018
Closed
alonttal added a commit that referenced this issue Mar 28, 2018
@alonttal
Routes: Added 3 new routes:
41975de 
	GET /users/verify/:token - this route is used to verify an
	verification email which is sent to new user mailbox
	POST /users/verify - this route is used to REsend a verification
	mail. the request body should contain the requesting user
	credentials.
	GET * - this is a default route that sohuld handle invalid
	requests (returns 404).
Modified Routes: Register and Login - from now on auth token will not be
created unless the user status is verified. Registeration will send and
verification mail to the new registered user. The Login route will first
check that the user is verified before creating an auth token.
User Schema: New property add - isVerified to distiguish between verified
	     and unverified accounts.
issues: #209 #210 #211 #212
alonttal added a commit that referenced this issue Mar 29, 2018
@alonttal
Services: Added documentation to mail and user-verificator services.
36f7848 
issues: #209 #210 #211 #212 #213
@alonttal
Copy link
Collaborator Author

done.

Roommates automation moved this from Backlog to Done Mar 29, 2018
@alonttal alonttal mentioned this issue Apr 5, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alonttal alonttal

Labels
Back-End MUST
Projects
Roommates
  
Done
Milestone
Mid Semester POC
Development

No branches or pull requests
1 participant
@alonttal