Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intergrate Vuex into Front end #228

Closed
alonttal opened this issue Apr 3, 2018 · 1 comment
Closed

Intergrate Vuex into Front end #228

alonttal opened this issue Apr 3, 2018 · 1 comment
Assignees
Projects

Comments

@alonttal
Copy link
Collaborator

alonttal commented Apr 3, 2018

Hi I started integrating Vuex into the front end for easier and better data management.
The idea is to use a single point of interest for data which is shared among various components.
It does not harm scalability since Vuex stores can be splitted into differnet modules.
It saves the need to listen to event or to send data ('props') for some cases, especially when the data need to be sended recusively to deeper component childs.
Of course not everything should be saved in the Vuex-store, but only this data that is shared globally.
For example: If a PriceTag component recieves the price as prop, Vuex should not be used.
On the contrast, after searching for apartments we save the apartments recieved from the server in the Vuex-store, thus allowing to return to the previous page while maintaining the apartments list.

Work done so far:

  • saving the searched apartments list in the vuex-Store and adapted all related compnents.

If you update anything related in the code remember to update everyone here & assign yourself to the issue.

@alonttal alonttal added this to the End of Semester Demo milestone Apr 3, 2018
@alonttal alonttal self-assigned this Apr 3, 2018
@alonttal alonttal added this to Backlog in Roommates via automation Apr 3, 2018
alonttal added a commit that referenced this issue Apr 3, 2018
		- Created a new "configuration" dir to store all related
		configuration. Added a Register-Icon file under it to
		set up our own icons (moved the related code from main.js).
		- changed imports to use "import" instead of "require".
Vuex:
		- Created vuex-store for global data management.
		- Now search apartments are managed with vuex.
		- Updated "Main.vue" "SearchSection.vue" &
		"SearchResults.vue" to use vuex.
Fixes:		- Added key to InterestedSection.vue v-for loop to
		remove the annoying warning that was shown when running
		Vue development environment.

Issues:	#228 #229
@alonttal
Copy link
Collaborator Author

This is done and well in the new front-end design.

Roommates automation moved this from Backlog to Done Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Roommates
  
Done
Development

No branches or pull requests

1 participant