Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create "Notifications" Component #378

Closed
alonttal opened this issue May 7, 2018 · 4 comments
Closed

Create "Notifications" Component #378

alonttal opened this issue May 7, 2018 · 4 comments
Assignees
Projects

Comments

@alonttal
Copy link
Collaborator

alonttal commented May 7, 2018

estimated time: 6 days

@alonttal alonttal added this to the Mid Semester POC milestone May 7, 2018
@alonttal alonttal self-assigned this May 7, 2018
@alonttal alonttal added this to Backlog in Roommates via automation May 7, 2018
alonttal added a commit that referenced this issue May 7, 2018
	- Created Notifications component.
	- Fixed a bug where sorted option were not aligned correctly on
	smaller screens.
issues: #378 #379
@alonttal alonttal moved this from Backlog to To do (planned for this week but not started) in Roommates May 8, 2018
@alonttal alonttal moved this from To do (planned for this week but not started) to In progress (started and working on it this week) in Roommates May 9, 2018
@alonttal
Copy link
Collaborator Author

alonttal commented May 9, 2018

improved component to show header and footer.
and to show interested notification

@alonttal
Copy link
Collaborator Author

updates:

  • added name of notifiers,
  • added linkage to the object the notification is related to,
  • added all current supported notification types,
  • fixed "show-more" option.

total time for all of these: 4 hours

alonttal added a commit that referenced this issue May 10, 2018
	- made socket management in Vuex
	- connecting to socket on login, register and when entering site
	(when logged in).
	- remove local token if token expires.
	- notification component: added the names of the notifiers
	- notification component: added linkage to the object id the notification is related to.
	- notification component: added all current supported notification types.
	- notification component: fixed "show-more" option
issues: #378 #399 #400 #401
alonttal added a commit that referenced this issue May 12, 2018
	- Added notifiers tooltip.
	- Added notifiers dialog.
	- Added link to notifiers' profile.
	- Mark notification as "read"
Issues: #378 #406 #407 #308
@alonttal
Copy link
Collaborator Author

alonttal commented May 12, 2018

Added notifiers tooltip.

related follow-ups:
#406
#407
#408

@alonttal
Copy link
Collaborator Author

alonttal commented May 12, 2018

done.
future improvements will be done when nesseccary.
time: 5 days

Roommates automation moved this from In progress (started and working on it this week) to Done May 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Roommates
  
Done
Development

No branches or pull requests

1 participant