Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Fix POST reviews route #414

Closed
alonttal opened this issue May 14, 2018 · 1 comment
Closed

[Bug] Fix POST reviews route #414

alonttal opened this issue May 14, 2018 · 1 comment
Assignees
@alonttal
Labels
Back-End Bug
Projects
Roommates
Milestone
Mid Semester POC

Comments

@alonttal
Copy link
Collaborator

when a review on the same area is published by the same user the route should return BAD_REQUEST.
while it does work that way, the route doesn't return. The problem is that the return statement is returning from the inner block of the "then" and not the whole route, I will fix it.
We can see the exception its test is throwing...
estimated time of fix: 1 hour.
@alonttal alonttal added this to the Mid Semester POC milestone May 14, 2018
@alonttal alonttal self-assigned this May 14, 2018
@alonttal alonttal added this to Backlog in Roommates via automation May 14, 2018
alonttal added a commit that referenced this issue May 14, 2018
@alonttal
Back-end:
c3aab04 
	- updated GET /apartment to allow sending list of apartment ids
	(as well a String)
	- Fixed POST /review route, where route didn't return after
	sending BAD_REQUEST when review about same location is published
	by the same user more then once.
issues: #441 #414
alonttal added a commit that referenced this issue May 14, 2018
@alonttal
Merge branch 'master' of github.com:TechnionYearlyProject/Roommates
1fcfd0d 
(see previous commit - fixing issue linkage)
issues: #411 #414
@alonttal alonttal mentioned this issue May 14, 2018
Open
@alonttal alonttal moved this from Backlog to To do (planned for this week but not started) in Roommates May 15, 2018
@alonttal alonttal moved this from To do (planned for this week but not started) to In progress (started and working on it this week) in Roommates May 17, 2018
@alonttal
Copy link
Collaborator Author

done.
actual time: ~1 hour (also fixed tests)

Roommates automation moved this from In progress (started and working on it this week) to Done May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alonttal alonttal

Labels
Back-End Bug
Projects
Roommates
  
Done
Milestone
Mid Semester POC
Development

No branches or pull requests
1 participant
@alonttal