Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add forms errors #431

Closed
idanyadgar opened this issue May 15, 2018 · 6 comments
Closed

Add forms errors #431

idanyadgar opened this issue May 15, 2018 · 6 comments
Assignees
Labels
Projects

Comments

@idanyadgar
Copy link
Contributor

idanyadgar commented May 15, 2018

Registration form:

No error is shown when a user tries to register with an already exists email.

Add comment:

No error is shown when a user tries to add an invalid comment.
No error is shown when an unauthorized user tries to add a comment.

Add apartment form:

No error is shown in case of an invalid input by the user.

@idanyadgar idanyadgar added this to the Mid Semester POC milestone May 15, 2018
@idanyadgar idanyadgar added this to Backlog in Roommates via automation May 15, 2018
@alonttal
Copy link
Collaborator

Hi Idan,
An unauthorized user should not have an option to add a comment. Did you mean "unverified"?

@idanyadgar
Copy link
Contributor Author

If I log in and stay in the main page enough time, the token expires and I become unauthorized, but I can still see the "add comment" option (it was there since I was logged in at first).
We should show the error, if there is any, when trying to comment (too short or any other error).

BTW, the option of "add comment" does not appear if the user is unverified, which is good, and its not the case I am talking about.

@idanyadgar
Copy link
Contributor Author

Also, I believe that there is no need of limiting the comment with a minimum length. Comments with even 1 character should be okay (we can think of a case when a comment with the content "6" is okay).

@idanyadgar idanyadgar removed the Bug label May 16, 2018
@alonttal
Copy link
Collaborator

Alright , cool i didn't remember what I did there..
I think the back end is limiting comment's length. If you plan to change it in the front then it should also be changed in the back.

@idanyadgar idanyadgar self-assigned this May 17, 2018
@idanyadgar
Copy link
Contributor Author

Time estimation: 2h.

@idanyadgar idanyadgar moved this from Backlog to To do (planned for this week but not started) in Roommates May 17, 2018
@idanyadgar idanyadgar moved this from To do (planned for this week but not started) to In progress (started and working on it this week) in Roommates May 17, 2018
@idanyadgar idanyadgar moved this from In progress (started and working on it this week) to To do (planned for this week but not started) in Roommates May 17, 2018
@idanyadgar idanyadgar moved this from To do (planned for this week but not started) to In progress (started and working on it this week) in Roommates May 17, 2018
@idanyadgar
Copy link
Contributor Author

idanyadgar commented May 17, 2018

Done.
Took 2.5h.

Roommates automation moved this from In progress (started and working on it this week) to Done May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Roommates
  
Done
Development

No branches or pull requests

2 participants