Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Front-end: Integrate reviews page with backend #501

Closed
omrihuller opened this issue May 29, 2018 · 3 comments
Closed

Front-end: Integrate reviews page with backend #501

omrihuller opened this issue May 29, 2018 · 3 comments
Assignees
@OrAbramovich
Labels
Back-End Front-End
Projects
Roommates
Milestone
End of Semester Demo

Comments

@omrihuller
Copy link
Collaborator

omrihuller commented May 29, 2018 •
edited by OrAbramovich
Loading

reviews are currently static.
The scope of this task is to fetch the reviews. Adding reviews task (incl. integration with back-end) is documented in issue #499
@omrihuller omrihuller added this to the End of Semester Demo milestone May 29, 2018
@omrihuller omrihuller added this to Backlog in Roommates via automation May 29, 2018
@omrihuller omrihuller moved this from Backlog to To do (planned for this week but not started) in Roommates May 29, 2018
@omrihuller omrihuller moved this from To do (planned for this week but not started) to Backlog in Roommates May 29, 2018
@omrihuller
Copy link
Collaborator Author

omrihuller commented May 29, 2018 •
edited by OrAbramovich
Loading

estimated: 3 hours

@omrihuller omrihuller moved this from Backlog to To do (planned for this week but not started) in Roommates May 29, 2018
@OrAbramovich OrAbramovich moved this from To do (planned for this week but not started) to In progress (started and working on it this week) in Roommates Jun 1, 2018
@OrAbramovich OrAbramovich changed the title Integrate reviews page with backend Front-end: Integrate reviews page with backend Jun 3, 2018
OrAbramovich added a commit that referenced this issue Jun 3, 2018
@OrAbramovich
Front-end: Integrate reviews page with back-end
8ffc79e 
Front End: add review to review page

Added the functions to load and store reviews (communicates with the back-end).

#501, #499
OrAbramovich added a commit that referenced this issue Jun 4, 2018
@OrAbramovich
Front-end: part of integrating reviews page with backend
7ea1dca 
Front-end: Fixed Bug: Reviews pros and cons are not displayed in front end

This commit prepares the Review Tile component for integrating with the back-end i.e. the publisher properties(name, image...) will be passed from the parent component that communicates  with the back-end. In addition, minor bug fix - the review object contains Pros and Cons keys and not pros and cons (case sensitive).

#501, #527
OrAbramovich added a commit that referenced this issue Jun 4, 2018
@OrAbramovich
Front-end: Integrate reviews page with backend
25d9e6d 
Front End: add review to review page
Front-end: Provide search functionality in the reviews page

This commit includes the parent component that gets and sets data of its childs: tile, search and add review. The commit includes the integration of all child components into the parent and integration of the parent with the back-end so all reviews functionalities work now.

#499, #501, #514
@OrAbramovich
Copy link
Collaborator

Actual time: 4 hours.

@OrAbramovich OrAbramovich mentioned this issue Jun 4, 2018
Open
@OrAbramovich
Copy link
Collaborator

Done.

Roommates automation moved this from In progress (started and working on it this week) to Done Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OrAbramovich OrAbramovich

Labels
Back-End Front-End
Projects
Roommates
  
Done
Milestone
End of Semester Demo
Development

No branches or pull requests
2 participants
@OrAbramovich @omrihuller