Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ProcessVariables property in the FetchAndLock request #47

Merged
merged 2 commits into from
Feb 13, 2022

Conversation

amd989
Copy link
Contributor

@amd989 amd989 commented Feb 4, 2022

Used to filter the external tasks (during FetchAndLock) using the variables contained within the workflow instance.
This property is available since Camunda Engine version 7.9

From API docs:
https://docs.camunda.org/manual/7.9/reference/rest/external-task/fetch/#request-body

processVariables A JSON object used for filtering tasks based on process instance variable values. A property name of the object represents a process variable name, while the property value represents the process variable value to filter tasks by.

Used to filter the external tasks using the variables contained within the workflow instance
This property is available since Camunda Engine version 7.9

From API docs:
https://docs.camunda.org/manual/7.9/reference/rest/external-task/fetch/#request-body
@TechnoBerry
Copy link
Owner

@amd989 thank you for your contribution! I will look at your PR a little later

@codecov-commenter
Copy link

Codecov Report

Merging #47 (05d63d8) into master (937926a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
+ Coverage   93.59%   93.61%   +0.01%     
==========================================
  Files          35       35              
  Lines         359      360       +1     
  Branches        7        7              
==========================================
+ Hits          336      337       +1     
  Misses         21       21              
  Partials        2        2              
Impacted Files Coverage Δ
src/Camunda.Worker/Client/FetchAndLockRequest.cs 100.00% <ø> (ø)
src/Camunda.Worker/Execution/HandlerMetadata.cs 100.00% <ø> (ø)
...c/Camunda.Worker/Execution/StaticTopicsProvider.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 937926a...05d63d8. Read the comment docs.

@TechnoBerry TechnoBerry merged commit 83fde89 into TechnoBerry:master Feb 13, 2022
@TechnoBerry
Copy link
Owner

@amd989 thank you for your contribution!

@amd989 amd989 deleted the feature/fetchfilters branch February 14, 2022 14:14
@amd989
Copy link
Contributor Author

amd989 commented Feb 14, 2022

@amd989 thank you for your contribution!

@AMalininHere Thank you for this cool library!

Do you have an ETA when the next nuget package is going to drop?
Thanks!

@TechnoBerry
Copy link
Owner

I just created a release with a new version: https://github.com/AMalininHere/camunda-worker-dotnet/releases/tag/0.13.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants