[DCK] Remove inbox containers, use internal networks #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The inbox proxies were a trick to isolate POP3/IMAP (or any other TCP) connections when a database got restored into a non-production environment. Since Docker 1.10, internal networks are natively supported, which means that any in/out communication outside the container stack gets automatically blocked. From now on, you can just configure incoming mail as usual in your Odoo instances with the safety that those incoming mails will not be read outside the production environment. If you still need outside world communication for devel or test environments, you can enable it by switching the internal boolean, or by adding a public network with public access and attaching it to the containers that need it (usually just Odoo). Note that for this to have a real effect, the `inverseproxy_shared` network must be internal too in test environments. Fixes #98
pedrobaeza
reviewed
Jan 25, 2018
| @@ -20,6 +20,8 @@ services: | |||
| PIP_INSTALL_ODOO: "false" | |||
| CLEAN: "false" | |||
| COMPILE: "false" | |||
| networks: | |||
| - public | |||
There was a problem hiding this comment.
Yes, in this case the running container needs to connect to the network to download git code from github usually.
yajo
added a commit
that referenced
this pull request
Jan 25, 2018
It's important to update and benefit from #117
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inbox proxies were a trick to isolate POP3/IMAP (or any other TCP) connections when a database got restored into a non-production environment.
Since Docker 1.10, internal networks are natively supported, which means that any in/out communication outside the container stack gets automatically blocked.
From now on, you can just configure incoming mail as usual in your Odoo instances with the safety that those incoming mails will not be read outside the production environment.
If you still need outside world communication for devel or test environments, you can enable it by switching the internal boolean, or by adding a public network with public access and attaching it to the containers that need it (usually just Odoo).
Note that for this to have a real effect, the
inverseproxy_sharednetwork must be internal too in test environments.Fixes #98