Do not --upgrade when installing pip dependencies #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can lead to unexpected or unneeded upgrades, making downstream images bigger and less stable. If you really need a newer (or older) version of any dependency than the one bundled (the one shipped from Odoo `requirements.txt` file), all you have to do is pin it in the scaffolding's `pip.txt` file.
yajo
added a commit
that referenced
this pull request
Apr 2, 2019
Being practical, most of the time you need to install this library from git master. Since #213 adding [the corresponding line][1] to the scaffolding didn't actually install the version from master. The pip requirements file doesn't have a way to force updating a dependency when it is already installed from git. It seems the easiest way to fix the situation is to remove `openupgradelib` from the base image. If you really need it, install it when building your subimage, either from pip or from git, however you want. [1]: https://github.com/Tecnativa/doodba-scaffolding/blob/55a5e1b3ba65bec8604f3260e361f8b6a1d64b2e/odoo/custom/dependencies/pip.txt#L1
Merged
yajo
added a commit
that referenced
this pull request
Apr 2, 2019
Being practical, most of the time you need to install this library from git master. Since #213 adding [the corresponding line][1] to the scaffolding didn't actually install the version from master. The pip requirements file doesn't have a way to force updating a dependency when it is already installed from git. It seems the easiest way to fix the situation is to remove `openupgradelib` from the base image. If you really need it, install it when building your subimage, either from pip or from git, however you want. [1]: https://github.com/Tecnativa/doodba-scaffolding/blob/55a5e1b3ba65bec8604f3260e361f8b6a1d64b2e/odoo/custom/dependencies/pip.txt#L1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can lead to unexpected or unneeded upgrades, making downstream images bigger and less stable.
If you really need a newer (or older) version of any dependency than the one bundled (the one shipped from Odoo
requirements.txtfile), all you have to do is pin it in the scaffolding'spip.txtfile.