[Enhancement] Add option to build as shared libraries #67
+37
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add the option
MALLOY_BUILD_SHARED
, which causes all libraries to be build as their shared versions (.dll
on windows,.so
on linux, etc). Since generator expressions cannot be used foradd_library(.. [SHARED|STATIC])
I used an if statement and put it in a function (malloy_add_library
).Additionally, all shared libraries and binaries are now place in
<builddir>/bin
so stuff will actually run under windows. This is set on a per-target basis to avoid leaking into consumer builds. I think it is better to do this across the board rather than special case windows + shared configuration, since that introduces possible confusion and additional complexity. I am happy to change this though.As discussed in #55 there might be issues with linking on windows, the CI seems to be fine though so hopefully its no longer a thing.
Closes: #55