-
Notifications
You must be signed in to change notification settings - Fork 65
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Emit Error when parsing FromMeta containing NestedMeta::Lit (#193)
darling silently ignored literals in NestedMeta, which could indirectly cause confusing error messages if the user provided something that wasn't of the intended format. This update makes that error more explicit, and includes tests to showcase the behavior. Fixes #192
- Loading branch information
1 parent
fad4cb7
commit 161587a
Showing
2 changed files
with
77 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
use darling::{Error, FromMeta}; | ||
use syn::parse_quote; | ||
|
||
#[derive(Debug, FromMeta)] | ||
struct Meta { | ||
#[darling(default)] | ||
meta1: Option<String>, | ||
#[darling(default)] | ||
meta2: bool, | ||
} | ||
|
||
#[test] | ||
fn nested_meta_meta_value() { | ||
let meta = Meta::from_list(&vec![parse_quote! { | ||
meta1 = "thefeature" | ||
}]) | ||
.unwrap(); | ||
assert_eq!(meta.meta1, Some("thefeature".to_string())); | ||
assert_eq!(meta.meta2, false); | ||
} | ||
|
||
#[test] | ||
fn nested_meta_meta_bool() { | ||
let meta = Meta::from_list(&vec![parse_quote! { | ||
meta2 | ||
}]) | ||
.unwrap(); | ||
assert_eq!(meta.meta1, None); | ||
assert_eq!(meta.meta2, true); | ||
} | ||
|
||
#[test] | ||
fn nested_meta_lit_string_errors() { | ||
let err = Meta::from_list(&vec![parse_quote! { | ||
"meta2" | ||
}]) | ||
.unwrap_err(); | ||
assert_eq!( | ||
err.to_string(), | ||
Error::unsupported_format("literal").to_string() | ||
); | ||
} | ||
|
||
#[test] | ||
fn nested_meta_lit_integer_errors() { | ||
let err = Meta::from_list(&vec![parse_quote! { | ||
2 | ||
}]) | ||
.unwrap_err(); | ||
assert_eq!( | ||
err.to_string(), | ||
Error::unsupported_format("literal").to_string() | ||
); | ||
} | ||
|
||
#[test] | ||
fn nested_meta_lit_bool_errors() { | ||
let err = Meta::from_list(&vec![parse_quote! { | ||
true | ||
}]) | ||
.unwrap_err(); | ||
assert_eq!( | ||
err.to_string(), | ||
Error::unsupported_format("literal").to_string() | ||
); | ||
} |