Update lazy_static to 1.0 and bump version #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TedDriggs
requested changes
Dec 5, 2017
There was a problem hiding this comment.
Thanks for submitting this! A couple changes and we should be good to go. Please also update CHANGELOG.md; you should add this to the Unreleased Changes section at the top.
Given that the tests pass, I'm guessing nothing changed in lazy_static, but I am somewhat concerned that I can't find any release notes for their 1.0. Do you know if anything changed on their end?
Cargo.toml
Outdated
| @@ -15,11 +15,11 @@ readme = "README.md" | |||
| travis-ci = { repository = "TedDriggs/darling" } | |||
|
|
|||
| [dependencies] | |||
| darling_core = { version = "=0.2.1", path = "core" } | |||
| darling_core = { version = "=0.2.2", path = "core" } | |||
| darling_macro = { version = "=0.2.1", path = "macro" } | |||
There was a problem hiding this comment.
Please bump the version of darling_macro and darling as well; all 3 crates should have identical version numbers.
core/Cargo.toml
Outdated
| @@ -16,6 +16,6 @@ default = ["syn/full"] | |||
|
|
|||
| [dependencies] | |||
| ident_case = "1.0.0" | |||
| lazy_static = "0.2.8" | |||
| lazy_static = "1" | |||
There was a problem hiding this comment.
Please use "1.0.0" for this, for consistency.
TedDriggs
approved these changes
Dec 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.