Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update syn to 0.12 and quote to 0.4 #20

Merged
merged 4 commits into from
Jan 26, 2018
Merged

Conversation

Eijebong
Copy link
Contributor

No description provided.

@Eijebong
Copy link
Contributor Author

I didn't rename Data nor VariantData to match syn's new way of naming stuff but I can do that if you want to (this is already a breaking change anyway)

@TedDriggs
Copy link
Owner

Wow, thank you so much for contributing all this. My goal with Body and VariantData is to match the types exported from syn, so if you don't mind switching them I'll start writing up the release notes.

I'm also going to try aliasing the old names to the new types and see if things work; that would at least give library consumers a chance to get warnings before things break.

@TedDriggs TedDriggs self-requested a review January 24, 2018 21:58
@Eijebong
Copy link
Contributor Author

There, I also added both type aliases you wanted to add

@TedDriggs TedDriggs merged commit f9f2184 into TedDriggs:master Jan 26, 2018
@TedDriggs TedDriggs mentioned this pull request Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants