Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support proc-macro2/nightly #24

Merged
merged 1 commit into from Mar 7, 2018
Merged

Conversation

kdy1
Copy link
Contributor

@kdy1 kdy1 commented Mar 4, 2018

Fixes #23.

::darling style paths only works with Span::call_site().

Note that tests fails with proc_macro::__internal::with_sess() called before set_parse_sess()! if proc- macro2/nightly is enabled because proc_macro's apis cannot be called from non-proc-macro code.

@TedDriggs
Copy link
Owner

::darling style paths only works with Span::call_site().

I'm not fully understanding this; do you mind expanding on it a bit? Thanks for submitting this PR; going to test it locally then will approve and ship an updated crate if all goes well.

@kdy1
Copy link
Contributor Author

kdy1 commented Mar 7, 2018

extern crate from call_site (including user-written ones) does not work for def_site because macro hygiene doesn't want spans from multiple places to be mixed.

@TedDriggs TedDriggs merged commit 30b5231 into TedDriggs:master Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants