Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distinguish root and non-root modules, detect non-inlined modules #6

Merged
merged 2 commits into from
Jun 19, 2019
Merged

Distinguish root and non-root modules, detect non-inlined modules #6

merged 2 commits into from
Jun 19, 2019

Conversation

jethrogb
Copy link
Contributor

@jethrogb jethrogb commented Jun 5, 2019

  • Distinguish root and non-root modules, lib.rs and main.rs are not special
    • Add builder type to configure inlining behavior
    • This changes how resolution works for the initial file passed to parse_and_inline_modules, so also bumped the crate version.
  • Add an option to detect non-inlined modules

TedDriggs
TedDriggs approved these changes Jun 12, 2019
View reviewed changes
Copy link
Owner

@TedDriggs TedDriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change requested, but otherwise LGTM.

src/lib.rs Show resolved Hide resolved
@jethrogb
Copy link
Contributor Author

Now that the changes have been made, could you merge this and do a crates.io release? Then I can publish my own crate based on this.

@TedDriggs TedDriggs merged commit f9c646a into TedDriggs:master Jun 19, 2019
@TedDriggs
Copy link
Owner

Update published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TedDriggs TedDriggs TedDriggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jethrogb @TedDriggs