Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hybrid] Template body exceeds intended template width in mobile Gmail #253

Open
nfakop opened this issue Nov 20, 2020 · 2 comments
Open
Labels
Help Wanted! looking for someone to pair with or solve

Comments

@nfakop
Copy link

nfakop commented Nov 20, 2020

Describe the bug
This is similar with 151, but affects hybrid template and has nothing to do with 2 columns (i tested it without columns and the bug persists)

To Reproduce

  1. Which template? Hybrid
  2. Which email clients and/or devices are affected? Android gmail app

Screenshots
1
2
3

Investigation
I removed u ~ div .email-container css styling and fixed it. See screenshots below. It is interesting that the bug does not show up, if the email is part of a conversation. Probably u ~ div .email-container selector does not target at all.

Screenshots (removed u ~ div .email-container)
1
2
3

@TedGoas
Copy link
Collaborator

TedGoas commented Nov 20, 2020

@nfakop Thanks for reporting and suggesting a fix, I'll dig into it!

@TedGoas
Copy link
Collaborator

TedGoas commented Nov 23, 2020

@nfakop Using Email on Acid to test yielded some interesting results.

First I tested the original code in this repo and could not reproduce the issue you linked above.

Next I removed the CSS you suggested and refreshed and saw no change in Gmail on android. On one hand, that code was for Gmail on iOS, so it makes sense that it wouldn't impact Android. On the other hand, Gmail has updated many times since that CSS was written so maybe it's obsolete?

Out of curiosity, did you test your email in iOS Gmail after removing this CSS? I'll try and track down a copy of Gmail on iOS to test.

@TedGoas TedGoas added the Help Wanted! looking for someone to pair with or solve label Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted! looking for someone to pair with or solve
Projects
None yet
Development

No branches or pull requests

2 participants