Skip to content
This repository has been archived by the owner on Aug 28, 2022. It is now read-only.

Added picture links and links completion #2

Closed
wants to merge 1 commit into from

Conversation

ASMfreaK
Copy link

Hello! Thanks for the nice repo!
Here is a new extension for the wiki!

Signed-off-by: delphi <cpp.create@gmail.com>
@TeddyDD
Copy link
Owner

TeddyDD commented Aug 24, 2018

Hi! Thanks for your contribution. I need to reviews your changes carefully since they add quite a lot of complexity. I noticed some issues:

  • wiki command does not show completion

  • after image expansion with @ tag you can't go to new line with enter, you have to exit inset mode and enter it again

  • not sure if @+ syntax is good idea. Maybe ! should be modifier and user would create pages in the old way? WDYT?

Copy link
Owner

@TeddyDD TeddyDD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review

} }
}
hook buffer InsertChar \n -group wiki %{
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is separate hook necessary?

wiki.kak Show resolved Hide resolved
set-option -add buffer completers option=wiki_completions
hook buffer -group wiki InsertIdle .* %{ try %{
execute-keys -draft <a-h><a-k>\B(@(\+|!)).\z<ret>
echo 'completing ...'
Copy link
Owner

@TeddyDD TeddyDD Aug 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this echo, no need to be verbose

@ASMfreaK
Copy link
Author

I'll reiterate on this. I'm sorry. I've posted it half asleep, so it is very messy. I've spotted a very disappointing typo in README.md too.

@TeddyDD
Copy link
Owner

TeddyDD commented Aug 24, 2018

no worries, I have typos all over the place :) I really like idea of image links and completion, and it works quite well. Actually only thing I don't like is + sign required for creating pages, but it shoudn't be too hard to change.

@TeddyDD
Copy link
Owner

TeddyDD commented Jan 2, 2019

I'm integrating some features from this pr in https://github.com/TeddyDD/kakoune-wiki/tree/update-07 branch:

  • expand picture command
  • @!image syntax
  • completion

@TeddyDD
Copy link
Owner

TeddyDD commented Nov 22, 2021

I'm rewriting this plugin from scratch. Closing this PR since it won't apply to new version.

@TeddyDD TeddyDD closed this Nov 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants