-
Notifications
You must be signed in to change notification settings - Fork 5
Added picture links and links completion #2
Conversation
Signed-off-by: delphi <cpp.create@gmail.com>
Hi! Thanks for your contribution. I need to reviews your changes carefully since they add quite a lot of complexity. I noticed some issues:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review
} } | ||
} | ||
hook buffer InsertChar \n -group wiki %{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is separate hook necessary?
set-option -add buffer completers option=wiki_completions | ||
hook buffer -group wiki InsertIdle .* %{ try %{ | ||
execute-keys -draft <a-h><a-k>\B(@(\+|!)).\z<ret> | ||
echo 'completing ...' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this echo, no need to be verbose
I'll reiterate on this. I'm sorry. I've posted it half asleep, so it is very messy. I've spotted a very disappointing typo in README.md too. |
no worries, I have typos all over the place :) I really like idea of image links and completion, and it works quite well. Actually only thing I don't like is |
I'm integrating some features from this pr in https://github.com/TeddyDD/kakoune-wiki/tree/update-07 branch:
|
I'm rewriting this plugin from scratch. Closing this PR since it won't apply to new version. |
Hello! Thanks for the nice repo!
Here is a new extension for the wiki!