-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance #265
Closed
Maintenance #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 24dcce7.
01. Added customEmojiFilter helper function that will filter out custom emojis (uploaded to discord server by user). Why: otherwise they're displayed in raw html format, since there're no emojis to translate them to; 02. Added replaceAtWithHash helper function that will filter replace '@' with '#'. Why: '@' is used as an inner reference symbol in Telegram which leads to posts transferred from Discord (if they had any @-mentions in it) to have a lot of unexpected links leading to random channels; 03. Added replaceExcessiveSpaces helper function that will filter out excessive (2 or more) whitespaces from the output. Why: after removing custom emojis html output frequently ends up with excessive spaces; 04. Added removeNewlineSpaces helper function that will filter out whitespaces placed at the beginning of the newline. Why: after removing custom emojis that were placed at the beginning of the newline html output ends up with an unneeded space;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to #256