New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added four new helpers for discord2telegram processing #270
Conversation
01. Added customEmojiFilter helper function that will filter out custom emojis (uploaded to discord server by user). Why: otherwise they're displayed in raw html format, since there're no emojis to translate them to; 02. Added replaceAtWithHash helper function that will filter replace '@' with '#'. Why: '@' is used as an inner reference symbol in Telegram which leads to posts transferred from Discord (if they had any @-mentions in it) to have a lot of unexpected links leading to random channels; 03. Added replaceExcessiveSpaces helper function that will filter out excessive (2 or more) whitespaces from the output. Why: after removing custom emojis html output frequently ends up with excessive spaces; 04. Added removeNewlineSpaces helper function that will filter out whitespaces placed at the beginning of the newline. Why: after removing custom emojis that were placed at the beginning of the newline html output ends up with an unneeded space;
Looks good so far. Thanks for the contribution |
No, this does not look good at all.
Generally, the messages should stay as similar as possible on both platforms. Having lots of random changes everywhere makes it very confusing and error-prone. |
@Fabian42 I agree that it might seem too radical for some users. For my personal use case this is perfect though. Anyway, I definitely agree that we might not want to force this on everyone. I think allowing users to enable/disable this behaviour should be enough to address your concerns. What do you think? |
Maybe three options for #1: current, deleted or some placeholder. Since I don't see the point of #2, I won't suggest options, but one of them should definitely be how it is now. #3 and #4 shouldn't be needed at all, just let #1 check if there's (non-newline) whitespace before and after it and then remove one of them. |
the new settings default to false
Sorry for that, my brain was a bit broke Moved it over to https://github.com/TediCross/TediCross/tree/dev and reset master to the old state |
the new settings default to false
the new settings default to false
the new settings default to false
Added 4 new helpers to clean up output when using discord2telegram processing