Fix #346 #347
Merged
Fix #346 #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Exzender
commented
Aug 22, 2023
Exzender
commented
- Enable preview for the first link only in the regular message (when useEmbeds set to 'never'). So if the user wants to see link previews - he should disable embeds in bot config file.
- Markdown link format works pretty good in regular messages, except the one, when link caption = link url (when text link auto formatted as link by Telegram). So in this solution is to replace full URL in link caption with word 'link' - in that case discord displays link correctly.
|
Added one more fix: command with slash does not detected as 'command' on Telegram side - so was not processed. |
|
One more fix: when sendUsernames set to off message header (from Telegram) becomes empty - bot failed when tried to set empty title for Embed. |
Lulalaby
reviewed
Sep 2, 2023
Lulalaby
requested changes
Sep 11, 2023
|
can you rebase on dev? i've added the channel chat info as hotfix, so we'd have dup code with your pr now. |
|
nvm, did it myself :) |
… T→D Fixed: some issues in link formatting T→D
update: when only 1 link per post - not use Embed in 'auto' mode - to get web preview
…ed as config option discord.disableWebPreviewOnTelegram
Lulalaby
requested changes
Sep 11, 2023
Lulalaby
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.