Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image ratio not honored #1

Open
squidpunch opened this issue May 20, 2022 · 2 comments
Open

Image ratio not honored #1

squidpunch opened this issue May 20, 2022 · 2 comments

Comments

@squidpunch
Copy link

I'd love to try and find time to fix this as I have build something similar a while back but it was all HTML canvas driven and a bunch more state to retain sizes to scale, etc.

Documenting here in case you have a quick fix, or someone else has time to take a stab (before I dig in)

Currently I have an image 6000 x 4000 that when uploaded it doesnt keep the proper aspect ratio because the preview is set to 400x400

Example starting image
DSC01039

Example final image
remix-profile-pic

Versus preferred view (after properly adjusting image to be a square ratio
square
remix-profile-pic (1)

@TedisAgolli
Copy link
Owner

Hey! Thanks for the very clear report. The current implementation is fairly naive, just sticks the image in a 400x400 tag.
Was your manual solution here to just cut 1000 px from each side and then put that in a circle?
Another solution could be to let you use the circle to crop out a 400x400 part of the picture.

@squidpunch
Copy link
Author

squidpunch commented May 22, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants