Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: resolve redirect reloads parent #149

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

saibotsivad
Copy link
Collaborator

@saibotsivad saibotsivad commented Feb 9, 2022

Based on a conversation in the Discord chat, I thought it might be helpful to document (via tests) some specific redirect behavior.

@saibotsivad
Copy link
Collaborator Author

The second test that I added, I believe it should be passing as-is.

If I added a console log at the top of each resolve, like console.log(resolvedCount, stateName, params) then I would expect output like this:

0, app, {}
// first redirect to app.child
1, app, {}
2, app.child, {}
// second redirect to app.child.node with params
3, app, { anyKey: 'yes' }
4, app.child, { anyKey: 'yes' }
5, app.child.node, { anyKey: 'yes' }

But the actual output when I run it is like this:

0, app, {}
// first redirect to app.child
1, app, {}
2, app.child, {}

So it runs the resolve for app.child but doesn't finish redirecting to the app.child.node resolve, which I believe is incorrect behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant