New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Potentially misleading error when counts are not in expected range #89
Comments
@padix-key, CellTypist first tries |
Sorry for the late response. After source code inspection I also found this behavior and I think it is generally fine. However, in my opinion the error message does not convey the actual problem: If I have an |
@padix-key, error messages have been redesigned 42c2c1c |
If the count matrix is not
log1p
normalized to a maximum of 10000, Celltypist resorts toadata.raw.X
instead ofadata.X
.In my case
adata.raw
is not populated at all, so instead of hinting to the the unexpected counts, Celltypist raisesI would suggest adding an optional parameter, e.g.
enforce_x
,allow_raw_counts
or something like that,that converts the log message
into an exception.
The text was updated successfully, but these errors were encountered: