Teiid Connection service fixes #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ConnectionImpl * RelationalMessages * Rename variables to connection rather than data source for workspace side but leave for Teiid side * Use connection is error messages replacing data source * CachedTeiidImpl * Fetching a Teiid data source that does not exist results in an exception which causes refreshing the teiid cache to fail. First test whether a data source exists before getting it. * KomodoTeiidService * Cannot guarantee that a property's required flag is always set correctly so for now override the priority properties to always set 'required' to true
* CacheTeiidImpl * If a template is problematic, eg. salesforce-34, then avoid bringing down whole app by logging the error message rather than throwing the exception. * message.properties * Adds the cause exception message to the error message * IT_KomodoTeiidServiceDriverTests * The hashmap is in a random order so cannot guarantee the status message if first in the iterator so check all the response attributes to ensure expected message is available * AbstractKomodoServiceTest * Unit tests using undertow require apache base64 as undertow client and service use that implementation, whereas javascript implementation uses implementation akin to DatatypeConverter and jdk8 Base64. # Conflicts: # server/komodo-rest/src/test/java/org/komodo/rest/relational/AbstractKomodoServiceTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConnectionImpl
RelationalMessages
Rename variables to connection rather than data source for workspace
side but leave for Teiid side
Use connection is error messages replacing data source
CachedTeiidImpl
Fetching a Teiid data source that does not exist results in an exception
which causes refreshing the teiid cache to fail. First test whether a
data source exists before getting it.
KomodoTeiidService
Cannot guarantee that a property's required flag is always set correctly
so for now override the priority properties to always set 'required' to
true