Skip to content

Commit

Permalink
TEIIDDEs-1701: Incorrect relationship used during rename and move
Browse files Browse the repository at this point in the history
* Move and Rename Resource Refactorings are using the wrong relationship
  for finding other resources to modify. Like delete, they should be
  finding their dependents and not their dependencies.
  • Loading branch information
Paul Richardson committed May 8, 2013
1 parent d8476cb commit 367e562
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ public void checkValidFile(IFile relatedFile, RefactoringStatus validityStatus)
}
};

RefactorResourcesUtils.calculateRelatedResources(resource, status, callback, Relationship.DEPENDENCY);
RefactorResourcesUtils.calculateRelatedResources(resource, status, callback, Relationship.DEPENDENT);
}
} finally {
progressMonitor.done();
Expand Down Expand Up @@ -175,7 +175,7 @@ public RefactoringStatus checkFinalConditions(IProgressMonitor progressMonitor)
continue;
}

RefactorResourcesUtils.calculateRelatedResources(resource, status, new RelatedResourceCallback(pathPairs), Relationship.DEPENDENCY);
RefactorResourcesUtils.calculateRelatedResources(resource, status, new RelatedResourceCallback(pathPairs), Relationship.DEPENDENT);

} catch (Exception ex) {
UiConstants.Util.log(ex);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ public void checkValidFile(IFile relatedFile, RefactoringStatus validityStatus)
}
};

RefactorResourcesUtils.calculateRelatedResources(resource, status, callback, Relationship.DEPENDENCY);
RefactorResourcesUtils.calculateRelatedResources(resource, status, callback, Relationship.DEPENDENT);
}
} finally {
progressMonitor.done();
Expand Down Expand Up @@ -202,7 +202,7 @@ public RefactoringStatus checkFinalConditions(IProgressMonitor progressMonitor)
}

// Add changes for related resources
RefactorResourcesUtils.calculateRelatedResources(resource, status, callback, Relationship.DEPENDENCY);
RefactorResourcesUtils.calculateRelatedResources(resource, status, callback, Relationship.DEPENDENT);
}
}
finally {
Expand Down

0 comments on commit 367e562

Please sign in to comment.