Skip to content

Commit

Permalink
Fix eclipse warnings concerning NON-NLS comments
Browse files Browse the repository at this point in the history 
* Adds missing NON-NLS comments

* Removes unnecessary NON-NLS comments
  • Loading branch information
Paul Richardson committed Jul 13, 2012
1 parent 3e3219b commit 46f32b5
Show file tree
Hide file tree
Showing 25 changed files with 63 additions and 63 deletions.
2 changes: 1 addition & 1 deletion ...tivity.ui/src/org/teiid/datatools/connectivity/ui/plan/TeiidExplainSQLActionDelegate.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ private String getExecutionPlan( Connection sqlConnection,
String executionPlan = null;

if (sql == null || sql.length() == 0) {
throw new SQLException("An SQL statement is required to retrieve the execution plan");
throw new SQLException("An SQL statement is required to retrieve the execution plan"); //$NON-NLS-1$
}

Statement stmt = sqlConnection.createStatement();
Expand Down
2 changes: 1 addition & 1 deletion ....designer.advisor.ui/src/org/teiid/designer/advisor/ui/actions/ToggleAutoBuildAction.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public class ToggleAutoBuildAction extends Action implements
* The window for parenting dialogs associated with this action
*/
public ToggleAutoBuildAction(IWorkbenchWindow window) {
super("Build Automatically");
super("Build Automatically"); //$NON-NLS-1$
this.window = window;
setChecked(ResourcesPlugin.getWorkspace().isAutoBuilding());
}
Expand Down
2 changes: 1 addition & 1 deletion ...id.designer.advisor.ui/src/org/teiid/designer/advisor/ui/core/AdvisorSupplierFactory.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ public static String getPrimaryProjectScopeNature( IProject proj ) {
AdvisorUiConstants.UTIL.log(e);
}

return "NoNature";
return "NoNature"; //$NON-NLS-1$
}

public static boolean hasPrimaryProjectScopeNature(IProject proj, String id) {
Expand Down
4 changes: 2 additions & 2 deletions ...visor.ui/src/org/teiid/designer/advisor/ui/core/status/AdvisorStatusExtensionManager.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ public static IStatusContentProvider getProvider( final Object target ) {
if (target instanceof IProject) {
id = getPrimaryProjectScopeNature((IProject)target);
} else if (target instanceof IResource && ModelUtilities.isModelFile((IResource)target)) {
id = "Model";
id = "Model"; //$NON-NLS-1$
}

// create a NewChildAction for every new child type
Expand Down Expand Up @@ -144,6 +144,6 @@ private static String getPrimaryProjectScopeNature( IProject proj ) {
AdvisorUiConstants.UTIL.log(e);
}

return "NoNature";
return "NoNature"; //$NON-NLS-1$
}
}
2 changes: 1 addition & 1 deletion ...signer.advisor.ui/src/org/teiid/designer/advisor/ui/core/status/AdvisorStatusManager.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ public void dispose() {
}

protected void generateNewStatus() {
System.out.println("AdvisorStatusManager.generateNewStatus() (NO OP METHOD)");
System.out.println("AdvisorStatusManager.generateNewStatus() (NO OP METHOD)"); //$NON-NLS-1$
}

/**
Expand Down
2 changes: 1 addition & 1 deletion ...gner.advisor.ui/src/org/teiid/designer/advisor/ui/core/status/AdvisorStatusUpdateJob.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public boolean belongsTo( Object family ) {
// Implementation of abstract methods:
@Override
protected IStatus run( IProgressMonitor monitor ) {
System.out.println(" >>> AdvisorStatusUpdateJob.run()");
System.out.println(" >>> AdvisorStatusUpdateJob.run()"); //$NON-NLS-1$
// let's wire this job up to listen for vdb context change events

this.statusManager.generateNewStatus();
Expand Down
2 changes: 1 addition & 1 deletion ...signer.advisor.ui/src/org/teiid/designer/advisor/ui/core/status/DefaultStatusManager.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ protected String getJobName() {
*/
@Override
protected void generateNewStatus() {
System.out.println("DefaultStatusProvider.generateNewStatus()");
System.out.println("DefaultStatusProvider.generateNewStatus()"); //$NON-NLS-1$
setCurrentStatus(StatusValidationConstants.STATUS_MSGS.ADVISOR_NO_PROJECT_SELECTED);
}

Expand Down
10 changes: 5 additions & 5 deletions ...igner.advisor.ui/src/org/teiid/designer/advisor/ui/core/status/DefaultStatusProvider.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public IStatus getDefaultStatus() {
*/
@Override
public String getDescription() {
return "Focused object not selected for advisor.";
return "Focused object not selected for advisor."; //$NON-NLS-1$
}

/**
Expand All @@ -49,7 +49,7 @@ public Image getImage( int id ) {
*/
@Override
public String getLinkTooltip( int id ) {
return "Default Status Tooltip";
return "Default Status Tooltip"; //$NON-NLS-1$
}

/**
Expand Down Expand Up @@ -92,7 +92,7 @@ public Image getStatusImage( int id ) {
*/
@Override
public String getText( int id ) {
return "Default Advisor Text";
return "Default Advisor Text"; //$NON-NLS-1$
}

/**
Expand All @@ -103,7 +103,7 @@ public String getText( int id ) {
@Override
public String getTitle() {
if( statusManager == null || statusManager.getCurrentObject() == null ) {
return "Advisor Object Title";
return "Advisor Object Title"; //$NON-NLS-1$
}

return ((IProject)statusManager.getCurrentObject()).getName();
Expand All @@ -115,7 +115,7 @@ private void initRowProviders() {
@Override
public String getId() {
// TODO Auto-generated method stub
return "defaultStatusProviderId";
return "defaultStatusProviderId"; //$NON-NLS-1$
}

@Override
Expand Down
18 changes: 9 additions & 9 deletions ...esigner.advisor.ui/src/org/teiid/designer/advisor/ui/scope/SelectModelingScopeDialog.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public class SelectModelingScopeDialog extends Dialog {
*/
public SelectModelingScopeDialog( Shell parent,
IProject project ) {
super(parent, "Select Modeling Scope");
super(parent, "Select Modeling Scope"); //$NON-NLS-1$
this.selectedProject = project;
}

Expand Down Expand Up @@ -74,16 +74,16 @@ private void init( Composite parent ) {
gridData.grabExcessVerticalSpace = true;
parent.setLayoutData(gridData);

WidgetFactory.createLabel(parent, GridData.HORIZONTAL_ALIGN_BEGINNING, 1, "Select modeling scope for the project: "
+ selectedProject.getName() + " ");
Group grpScaling = WidgetFactory.createGroup(parent, "Modeling Scope", GridData.FILL_HORIZONTAL);
WidgetFactory.createLabel(parent, GridData.HORIZONTAL_ALIGN_BEGINNING, 1, "Select modeling scope for the project: " //$NON-NLS-1$
+ selectedProject.getName() + " "); //$NON-NLS-1$
Group grpScaling = WidgetFactory.createGroup(parent, "Modeling Scope", GridData.FILL_HORIZONTAL); //$NON-NLS-1$

radioGeneralModeling = WidgetFactory.createRadioButton(grpScaling, "General");
radioRelationalModeling = WidgetFactory.createRadioButton(grpScaling, "Relational");
radioXMLModeling = WidgetFactory.createRadioButton(grpScaling, "XML + Relational");
radioWebServiceModeling = WidgetFactory.createRadioButton(grpScaling, "Web Services + XML + Relational");
radioGeneralModeling = WidgetFactory.createRadioButton(grpScaling, "General"); //$NON-NLS-1$
radioRelationalModeling = WidgetFactory.createRadioButton(grpScaling, "Relational"); //$NON-NLS-1$
radioXMLModeling = WidgetFactory.createRadioButton(grpScaling, "XML + Relational"); //$NON-NLS-1$
radioWebServiceModeling = WidgetFactory.createRadioButton(grpScaling, "Web Services + XML + Relational"); //$NON-NLS-1$

vdbProjectCheckBox = WidgetFactory.createCheckBox(parent, "VDB Project");
vdbProjectCheckBox = WidgetFactory.createCheckBox(parent, "VDB Project"); //$NON-NLS-1$

try {
setIntialScope();
Expand Down
2 changes: 1 addition & 1 deletion ...signer.advisor.ui/src/org/teiid/designer/advisor/ui/scope/SetModelProjectScopeAction.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public class SetModelProjectScopeAction extends Action implements ISelectionList

public SetModelProjectScopeAction() {
super();
setText("Change Modeling Scope");
setText("Change Modeling Scope"); //$NON-NLS-1$
setImageDescriptor(UiPlugin.getDefault().getImageDescriptor(PluginConstants.Images.MODEL));
}

Expand Down
8 changes: 4 additions & 4 deletions ...isor.ui/src/org/teiid/designer/advisor/ui/suppliers/ModelValidationStatusRowProvider.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public Image getImage( IStatus status ) {
*/
@Override
public String getImageTooltip( IStatus status ) {
return "Model Validation Tooltip";
return "Model Validation Tooltip"; //$NON-NLS-1$
}

/**
Expand All @@ -73,7 +73,7 @@ public Image getLinkImage( IStatus status ) {
*/
@Override
public String getLinkTooltip( IStatus status ) {
return "Model Validation Tooltip";
return "Model Validation Tooltip"; //$NON-NLS-1$
}

/**
Expand All @@ -83,7 +83,7 @@ public String getLinkTooltip( IStatus status ) {
*/
@Override
public String getText( IStatus status ) {
return "Model Validation Text";
return "Model Validation Text"; //$NON-NLS-1$
}

/**
Expand All @@ -93,7 +93,7 @@ public String getText( IStatus status ) {
*/
@Override
public String getTextTooltip( IStatus status ) {
return "Model Validation Text Tooltip";
return "Model Validation Text Tooltip"; //$NON-NLS-1$
}

}
2 changes: 1 addition & 1 deletion ...c/org/teiid/designer/advisor/ui/suppliers/relational/RelationalModelingStatusManager.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ protected String getJobName() {
*/
@Override
protected void generateNewStatus() {
System.out.println("RelationalModelingStatusManager.generateNewStatus()");
System.out.println("RelationalModelingStatusManager.generateNewStatus()"); //$NON-NLS-1$
this.helper.setCurrentProject((IProject)getCurrentObject());
setCurrentStatus(helper.getCurrentStatus());
}
Expand Down
8 changes: 4 additions & 4 deletions .../org/teiid/designer/advisor/ui/suppliers/relational/RelationalModelingStatusProvider.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public IStatus getDefaultStatus() {
*/
@Override
public String getDescription() {
return "Relational Source and View Modeling Description";
return "Relational Source and View Modeling Description"; //$NON-NLS-1$
}

/**
Expand Down Expand Up @@ -71,7 +71,7 @@ public Image getImage( int id ) {
*/
@Override
public String getLinkTooltip( int id ) {
return "Relational Modeling Tooltip";
return "Relational Modeling Tooltip"; //$NON-NLS-1$
}

/**
Expand Down Expand Up @@ -114,7 +114,7 @@ public Image getStatusImage( int id ) {
*/
@Override
public String getText( int id ) {
return "Relational Modeling Text";
return "Relational Modeling Text"; //$NON-NLS-1$
}

/**
Expand All @@ -125,7 +125,7 @@ public String getText( int id ) {
@Override
public String getTitle() {
if( statusManager == null || statusManager.getCurrentObject() == null ) {
return "Relational Modeling Title";
return "Relational Modeling Title"; //$NON-NLS-1$
}

return ((IProject)statusManager.getCurrentObject()).getName();
Expand Down
2 changes: 1 addition & 1 deletion ...org/teiid/designer/advisor/ui/suppliers/relational/RelationalProjectValidationHelper.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ public RelationalProjectValidationHelper( IProject project ) {

// Needed to wrap in transaction so these don't cause UNDO events.
public AdvisorStatus getCurrentStatus() {
System.out.println(" >>> RelationalProjectValidationHelper.getCurrentStatus()");
System.out.println(" >>> RelationalProjectValidationHelper.getCurrentStatus()"); //$NON-NLS-1$
validating = true;
// System.out.println("WebServiceValidationHelper.getCurrentStatus() ---------- START ------------------");
AdvisorStatus status = null;
Expand Down
8 changes: 4 additions & 4 deletions .../src/org/teiid/designer/advisor/ui/suppliers/relational/SourceModelStatusRowProvider.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public Image getImage( IStatus status ) {
*/
@Override
public String getImageTooltip( IStatus status ) {
return "Source Models Tooltip";
return "Source Models Tooltip"; //$NON-NLS-1$
}

/**
Expand All @@ -73,7 +73,7 @@ public Image getLinkImage( IStatus status ) {
*/
@Override
public String getLinkTooltip( IStatus status ) {
return "Source Models Tooltip";
return "Source Models Tooltip"; //$NON-NLS-1$
}

/**
Expand All @@ -83,7 +83,7 @@ public String getLinkTooltip( IStatus status ) {
*/
@Override
public String getText( IStatus status ) {
return "Source Models Text";
return "Source Models Text"; //$NON-NLS-1$
}

/**
Expand All @@ -93,7 +93,7 @@ public String getText( IStatus status ) {
*/
@Override
public String getTextTooltip( IStatus status ) {
return "Source Models Text Tooltip";
return "Source Models Text Tooltip"; //$NON-NLS-1$
}

}
8 changes: 4 additions & 4 deletions ...ui/src/org/teiid/designer/advisor/ui/suppliers/relational/ViewModelStatusRowProvider.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public Image getImage( IStatus status ) {
*/
@Override
public String getImageTooltip( IStatus status ) {
return "View Models Tooltip";
return "View Models Tooltip"; //$NON-NLS-1$
}

/**
Expand All @@ -70,7 +70,7 @@ public Image getLinkImage( IStatus status ) {
*/
@Override
public String getLinkTooltip( IStatus status ) {
return "View Models Tooltip";
return "View Models Tooltip"; //$NON-NLS-1$
}

/**
Expand All @@ -80,7 +80,7 @@ public String getLinkTooltip( IStatus status ) {
*/
@Override
public String getText( IStatus status ) {
return "View Models Text";
return "View Models Text"; //$NON-NLS-1$
}

/**
Expand All @@ -90,7 +90,7 @@ public String getText( IStatus status ) {
*/
@Override
public String getTextTooltip( IStatus status ) {
return "View Models Text Tooltip";
return "View Models Text Tooltip"; //$NON-NLS-1$
}

}
8 changes: 4 additions & 4 deletions ...advisor.ui/src/org/teiid/designer/advisor/ui/suppliers/xml/XmlModelStatusRowProvider.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public Image getImage( IStatus status ) {
*/
@Override
public String getImageTooltip( IStatus status ) {
return "Xml Models Tooltip";
return "Xml Models Tooltip"; //$NON-NLS-1$
}

/**
Expand All @@ -70,7 +70,7 @@ public Image getLinkImage( IStatus status ) {
*/
@Override
public String getLinkTooltip( IStatus status ) {
return "Xml Models Tooltip";
return "Xml Models Tooltip"; //$NON-NLS-1$
}

/**
Expand All @@ -80,7 +80,7 @@ public String getLinkTooltip( IStatus status ) {
*/
@Override
public String getText( IStatus status ) {
return "Xml Models Text";
return "Xml Models Text"; //$NON-NLS-1$
}

/**
Expand All @@ -90,7 +90,7 @@ public String getText( IStatus status ) {
*/
@Override
public String getTextTooltip( IStatus status ) {
return "Xml Models Text Tooltip";
return "Xml Models Text Tooltip"; //$NON-NLS-1$
}

}
2 changes: 1 addition & 1 deletion ....advisor.ui/src/org/teiid/designer/advisor/ui/suppliers/xml/XmlModelingStatusManager.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ protected String getJobName() {
*/
@Override
protected void generateNewStatus() {
System.out.println("XmlModelingStatusManager.generateNewStatus()");
System.out.println("XmlModelingStatusManager.generateNewStatus()"); //$NON-NLS-1$
this.helper.setCurrentProject((IProject)getCurrentObject());
setCurrentStatus(helper.getCurrentStatus());
}
Expand Down

0 comments on commit 46f32b5

Please sign in to comment.