Skip to content

Commit

Permalink
Makes the TP values into properties for use in target-platform pom
Browse files Browse the repository at this point in the history
* Disable the attachment of the teiid-designer.target platform since its
  identical to the target platform configuration now downloaded via mvn

* The generation of the teiid-designer.target can remain since devs can use
  this for specifying their TP in eclipse IDE

* Adds a README for developers to understand how to create a .target file
  for use with eclipse IDE
  • Loading branch information
Paul Richardson committed Oct 17, 2014
1 parent 138a564 commit 6689512
Show file tree
Hide file tree
Showing 5 changed files with 50 additions and 643 deletions.
28 changes: 18 additions & 10 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,13 @@

<!-- Specify our own TP using the JBT-IS rather than using the definition in the parent pom -->
<no-target-platform>true</no-target-platform>

<td.tpc.groupId>org.jboss.tools.integration-stack</td.tpc.groupId>
<td.tpc.artifactId>target-platform</td.tpc.artifactId>
<td.tpc.version>4.1.8.Final</td.tpc.version>
<td.tpc.type>target</td.tpc.type>
<td.tpc.classifier>base</td.tpc.classifier>

</properties>

<modules>
Expand Down Expand Up @@ -60,11 +67,12 @@
<echo>project.build.directory: ${project.build.directory}</echo>
<echo>eclipse.tycho.version: ${tychoVersion}</echo>
<echo>eclipse.target.version: ${targetEclipseVersion}</echo>
<echo>eclipse.target.platform.groupId: ${tpc.groupId}</echo>
<echo>eclipse.target.platform.group: ${tpc.group}</echo>
<echo>eclipse.target.platform.version: ${tpc.version}</echo>
<echo>eclipse.target.platform.kind: ${tpc.targetKind}</echo>
<echo>NOT.using.target.platform: ${no-target-platform}</echo>
<echo>not.using.jbt.parent.pom.tp: ${no-target-platform}</echo>
<echo>teiid.designer.tp.group.id: ${td.tpc.groupId}</echo>
<echo>teiid.designer.tp.artifact.id: ${td.tpc.artifactId}</echo>
<echo>teiid.designer.tp.version: ${td.tpc.version}</echo>
<echo>teiid.designer.tp.type: ${td.tpc.type}</echo>
<echo>teiid.designer.tp.classifier: ${td.tpc.classifier}</echo>
</target>
</configuration>
</execution>
Expand All @@ -80,11 +88,11 @@
<ignoreTychoRepositories>true</ignoreTychoRepositories>
<target>
<artifact>
<groupId>org.jboss.tools.integration-stack</groupId>
<artifactId>target-platform</artifactId>
<version>4.1.8.Final</version>
<type>target</type>
<classifier>base</classifier>
<groupId>${td.tpc.groupId}</groupId>
<artifactId>${td.tpc.artifactId}</artifactId>
<version>${td.tpc.version}</version>
<type>${td.tpc.type}</type>
<classifier>${td.tpc.classifier}</classifier>
</artifact>
</target>
</configuration>
Expand Down
2 changes: 1 addition & 1 deletion target-platform/.gitignore
Original file line number Diff line number Diff line change
@@ -1 +1 @@
target
teiid-designer.target
17 changes: 17 additions & 0 deletions target-platform/README
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
Creating a target platform for use in Eclipse Development

The Teiid Designer target platform (TP) is now the JBossTools Integration Stack base target (JBT-IS TP)
and as such is direclty referenced by maven when performing builds.

Developers, on the Teiid Designer project seeking to develop the codebase, should in the target-platform
directory, execute either

- build.sh
- build.bat

which will in turn execute maven with the generate-target profile located in the target-platform/pom.xml.
This will create the following:

- teiid-designer.target

which can be opened in eclipse and set as its target platform.
20 changes: 14 additions & 6 deletions target-platform/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,15 @@
<packaging>pom</packaging>

<build>
<!--
Commented out as no longer required since we can build
directly from JBT-IS using the target-platform config
specified in our parent pom. The teiid-designer.target
will remain to serve as a platform easily available to
developers loading the TP into an eclipse IDE.
-->
<plugins>
<!-- Attach the designer target to the configuration -->
<!--
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>build-helper-maven-plugin</artifactId>
Expand All @@ -39,6 +46,7 @@
</execution>
</executions>
</plugin>
-->
</plugins>
</build>

Expand All @@ -62,11 +70,11 @@
<configuration>
<artifactItems>
<artifactItem>
<groupId>org.jboss.tools.integration-stack</groupId>
<artifactId>target-platform</artifactId>
<version>4.1.8.Final</version>
<classifier>base</classifier>
<type>target</type>
<groupId>${td.tpc.groupId}</groupId>
<artifactId>${td.tpc.artifactId}</artifactId>
<version>${td.tpc.version}</version>
<type>${td.tpc.type}</type>
<classifier>${td.tpc.classifier}</classifier>
<overWrite>true</overWrite>
<outputDirectory>${basedir}</outputDirectory>
<destFileName>teiid-designer.target</destFileName>
Expand Down

0 comments on commit 6689512

Please sign in to comment.