TEIIDDES-1612: Fixes accumulation of inputs in transformation

* AttributeMappingHelper * The element collector visitor implementations store the returned elements in a field. As a consequence, using the visitor in a loop means the previously found elements are also returned with newly found elements. * Creates a new instance of the visitor each time it is required to avoiding erroneous caching of elements.
Teiid-Designer · Mar 7, 2013 · e1d4e43 · e1d4e43
1 parent bea4bf7
commit e1d4e43
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/...ner.transformation/src/org/teiid/designer/transformation/util/AttributeMappingHelper.java b/...ner.transformation/src/org/teiid/designer/transformation/util/AttributeMappingHelper.java
@@ -89,7 +89,6 @@ public static boolean updateAttributeMappings(Object transMappingRoot, Object tx
             List attrs = TransformationHelper.getTransformationTargetAttributes((EObject)transMappingRoot);       
 
             IQueryService queryService = ModelerCore.getTeiidQueryService();
-            IElementCollectorVisitor elementCollectorVisitor = queryService.getElementCollectorVisitor(true);
 
             // Iterate attributes, setting each mapping
             Iterator iter = attrs.iterator();
@@ -106,7 +105,13 @@ public static boolean updateAttributeMappings(Object transMappingRoot, Object tx
                     // Find element matching the attribute name (if it exists)
                     IExpression seSymbol = getSymbolWithName(projectedSymbols,colName);
                     if(seSymbol!=null) {
+                        /**
+                         * Note as per TEIIDDES-1612, the elementCollectorVisitor implementations stores
+                         * the found elements in a field so reuse of an existing instance must be avoided
+                         * when using a loop.
+                         */
                         // Get the ElementSymbols / corresponding EObjs
+                        IElementCollectorVisitor elementCollectorVisitor = queryService.getElementCollectorVisitor(true);
                         Collection elemSymbols = elementCollectorVisitor.findElements(seSymbol);
                         Collection<EObject> elemEObjs = TransformationSqlHelper.getElementSymbolEObjects(elemSymbols,command);
                         // Set Elem EObjs as inputs for attr Mapping