JBIDE-16133: Provide better feedback for incorrect admin password #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* JBoss[7]ServerUtil * TeiidServerAdapterFactory * Rather than catching JBoss exceptions (may be caused by incorrect security credentials) throw them instead and force UI components to catch and process them * TeiidServer * Better handle exceptions thrown when failing to connect to teiid instance * TeiidServerEditor * TeiidParentServerListener * Rather than just logging exceptions thrown when initialising the teiid instance, get the exception back to the user * DqpPlugin * API for handling exceptions by displaying them using an ErrorDialog * This is not ideal given that the DqpPlugin is technically a non-UI plugin despite depending on org.eclipse.ui. * At some point, this needs refactoring to set a UI provider for displaying exceptions in the UI.
ghost
assigned 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
security credentials) throw them instead and force UI components to
catch and process them
instance, get the exception back to the user
plugin despite depending on org.eclipse.ui.
exceptions in the UI.