Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Archlinux PKGBUILD #2

Merged
merged 4 commits into from
Jan 22, 2020
Merged

Add a Archlinux PKGBUILD #2

merged 4 commits into from
Jan 22, 2020

Conversation

chabad360
Copy link
Contributor

@chabad360 chabad360 commented Dec 18, 2019

This would be a first step for making binary packages generally available (although in this current state you'd push just the PKGBUILD and its corresponding .SRCINFO to the Archlinux aur and people would download the PKGBUILD and build it), you can use makepkg (on arch) to build a .pkg.tar.xz that would go with a release.

@chabad360 chabad360 marked this pull request as ready for review December 18, 2019 03:48
@TekWizely
Copy link
Owner

Hey @chabad360 ,

Thanks for taking the time to make this.

This looks like a reasonable start for a PKGBUILD file.

I found this as a source of info[1]

What I could not find is any example a go project (or any project) that keeps a PKGBUILD file in the source tree.

I checked the github pages of the example packages mentioned in [1].
I even searched github looking for projects with a PKGBUILD file[2] and couldn't find any clear examples of projects keeping their PKGBUILD file in the source tree.

So I'm just not sure where the PKGBUILD is supposed to live for a project

Can you shed any extra light on this?

Thanks in advance !

-TW

[1]https://wiki.archlinux.org/index.php/Go_package_guidelines
[2]https://github.com/search?q=filename%3APKGBUILD

@chabad360
Copy link
Contributor Author

chabad360 commented Dec 19, 2019 via email

@TekWizely
Copy link
Owner

Hey @chabad360 !

Q: What are the steps to getting this into AUR ? Do I need to create an account / submit a request / etc ?

Q: Whats the best / easiest way to test this PKGBUILD file locally? I tried starting an archlinux docker image and running makepkg but I think I'm still missing a few key points.

Thanks again for the assist - Now that the project is in homebrew, I'm excited to try to get into other package managers.

@chabad360
Copy link
Contributor Author

chabad360 commented Dec 27, 2019

Q: What are the steps to getting this into AUR ? Do I need to create an account / submit a request / etc ?

Well, I've done you one more, and already uploaded it to the AUR, if you want I'll hand over the package maintenance to you.

Q: Whats the best / easiest way to test this PKGBUILD file locally? I tried starting an archlinux docker image and running makepkg but I think I'm still missing a few key points.

You'll need to install the base-devel group and the run makepkg -s which will install the necessary packages for building that specific PKGBUILD.

@TekWizely
Copy link
Owner

OK I was able to test the file from this pr and build a tgz with /usr/bin/run and the LICENSE file, so thats cool!

Also cool that you already submitted a build to AUR !!

Some Q's regarding differences between that build file and this one:

< pkgver=r45.14598e7
---
> pkgver=0.1

Is that version number normal? ie r45.14598e7-1 - Looks odd.

< pkgname=run-git
---
> pkgname=run

Was there a reason it needed to be named run-git ?

<   'go'
---
>   'go-pie'

I don' t enough about either, just wondering why the change?

Lastly, Q: Has that build file been deployed or is it still pending some kind of approval?

Thanks again!

PS: Lastly lastly Q: Are you using run much at all, I'd love to hear how its working for you

@chabad360
Copy link
Contributor Author

Is that version number normal? ie r45.14598e7-1 - Looks odd.

String Meaning
r45 Revision/Commit 45
14598e7 Commit Hash
1 Build Version (+1 if a custom is applied, but source version remains the same)

The pkgver() function will automatically update this number as new commits are pushed to master, or -once you tag a release- it will use the latest tag as the version number.

Was there a reason it needed to be named run-git?

This is the naming convention for packages that are built from the git upstream.

I don't enough about either, just wondering why the change?

go-pie is meant to be used by the ABS (Arch Build System, the build system for official packages) or any other runner, as it provides certain security advantages. However, it conflicts with go which is what most people have installed on their system.

Has that build file been deployed or is it still pending some kind of approval?

It's been deployed.

Are you using run much at all, I'd love to hear how it's working for you

I haven't gotten much of a chance yet, as I'm busy with some other things, but once I get the chance, I'll be glad to my two cents.

@TekWizely
Copy link
Owner

@chabad360 Thanks for the detailed response !

... once you tag a release- it will use the latest tag as the version number.

Indeed I have several releases - Just tagged v0.7.0 a couple of hours ago - Hopefully it gets picked up.

It's been deployed.

SWEET - Ok so how would I use the deployed version to install run? i.e say I started from a fresh arch docker image, what would I type to install run within that image using the deployed pkg file?

Depending on how easy it is, it might be time for me to add a section in the README for it.

As always, thank you !

-TW

@chabad360
Copy link
Contributor Author

chabad360 commented Jan 6, 2020

There's no need for adding instructions to the README, just put a link to it, and Arch users will know what to do.

Hopefully it gets picked up.

It doesn't get picked up by the AUR, it's only checked locally on build.

P.s. if you give me some time, I'll put up a PKGBUILD for the pre-built binaries.

@TekWizely
Copy link
Owner

Hey @chabad360,

P.s. if you give me some time, I'll put up a PKGBUILD for the pre-built binaries.

That sounds great !

Q: Would you be able to submit an PR to update the Install section of the README with information that Archlinux users would find useful?

Lemme know, and have a great weekend!

-TW

@chabad360
Copy link
Contributor Author

Done #24

@TekWizely
Copy link
Owner

Hey @chabad360 ,

In adding NPM support, I decided to use the deployments folder store the package info.

With that pattern established, I'm okay storing this file within that folder structure as well.

Could you please:

  • Update the file location to be deployments/aur/PKGBUILD
  • Update the file content to match the one currently deployed in AUR

Thank you and please let me know if you have any questions.

-TW

@chabad360
Copy link
Contributor Author

Done!

@TekWizely TekWizely merged commit 8fefa67 into TekWizely:master Jan 22, 2020
@TekWizely
Copy link
Owner

Thanks !

@all-contributors please add @chabad360 for infra

@allcontributors
Copy link
Contributor

@TekWizely

I've put up a pull request to add @chabad360! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants