Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for INCLUDE directive #46

Merged
merged 6 commits into from
Jul 2, 2022
Merged

Adds support for INCLUDE directive #46

merged 6 commits into from
Jul 2, 2022

Conversation

TekWizely
Copy link
Owner

Imports goreleaser/fileglob for globbing support

Adds util.ReadFileIfExists helper method

Closes #44


cc: @nikolay , @charandas

Imports goreleaser/fileglob for globbing support

Adds util.ReadFileIfExists helper method
internal/ast/ast.go Outdated Show resolved Hide resolved
@TekWizely
Copy link
Owner Author

@nikolay can you experiment with this branch and see how it feels and if you have any feedback ?

@nikolay
Copy link

nikolay commented Jun 18, 2022

@TekWizely I will try it and provide feedback ASAP! Thank you!

Updates config.Runfile, config.RunfileAbs during includes
Adds Runfile to asserts
Prints Runfile on asssert errors
Treats glob patterns as optional
Treats non-glob patters as required

Fleshes out Readme for includes
Adds filename to assertion errors in Readme
l.Clear() // Discard
}

ignoreSpace(l)
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: This change is not relevant to the PR's goal, but I'm allowing it ...

@TekWizely
Copy link
Owner Author

@nikolay I think this is pretty close to baked, can you lemme know if you had a chance to test it and/or if you can test with the most recent changes?

Thanks!

@TekWizely
Copy link
Owner Author

@nikolay Unless i hear from you regarding any issues you've noticed, I'll likely release this over the weekend.

Do lemme know if you had a chance to try it, else keep an eye out for the PR merge and a new release !

-TW

@nikolay
Copy link

nikolay commented Jul 1, 2022

@TekWizely Sorry for being busy last few days. I will try it right now!

@nikolay
Copy link

nikolay commented Jul 1, 2022

@TekWizely Thank you, all the usecases I tried worked as expected! Please, release this! And thank you for the great job you've done with this project!

@TekWizely TekWizely merged commit 4ac3c88 into master Jul 2, 2022
@TekWizely TekWizely deleted the feature/include branch July 2, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support includes
2 participants